recommend sbt, not Activator #530
Conversation
and remove all mention of Activator from the site (well, except from some old release announcements)
|
review by @heathermiller @adriaanm @charafau @jarrodwb @eed3si9n @dwijnand @corruptmemory @tpolecat...? |
|
|
|
I think I might prefer landing at |
yeah, I was unsure about that. Eugene, Dale, you want to make the call there? |
|
Sure. Landing on the landing page makes sense. |
(in response to reviewer feedback)
| </a> | ||
| <p class="install"><a style="margin-left: 124px;" href="http://www.lightbend.com/activator/download">Need help installing?</a></p> | ||
| </div> | ||
| sbt is a popular build tool for Scala projects.<br/> |
There was a problem hiding this comment.
Should sbt be capitalized here? It is the beginning of a sentence.
There was a problem hiding this comment.
sbt is a proper noun like iPhone and eBay.
| @@ -7,7 +7,6 @@ title: Documentation Contributions | |||
| There are several ways you can help out with the improvement of Scala documentation. These include: | |||
|
|
|||
| * API Documentation in Scaladoc | |||
| * Code examples and tutorials in activator templates. | |||
There was a problem hiding this comment.
Sbt 13.13 has a new command that provides templates. Maybe this is worth mentioning.
There was a problem hiding this comment.
Would it be possible for sbt to provide some examples for basic projects?
There was a problem hiding this comment.
Anyway, this is the wrong place to suggest these changes. I think we're making suggestions for improving the getting started page, which is not the file we're commenting on (we're commenting on a contributing page)
There was a problem hiding this comment.
For the getting started page, you can point to http://www.scala-sbt.org/0.13/docs/sbt-new-and-Templates.html
There was a problem hiding this comment.
LGTM. Though I'd like to point out that the comments pointing out the sbt new command would be great for a rethink of the getting started guide. Perhaps also using some tips from @djspiewak's getting started guide gist
| @@ -7,7 +7,6 @@ title: Documentation Contributions | |||
| There are several ways you can help out with the improvement of Scala documentation. These include: | |||
|
|
|||
| * API Documentation in Scaladoc | |||
| * Code examples and tutorials in activator templates. | |||
| @@ -7,7 +7,6 @@ title: Documentation Contributions | |||
| There are several ways you can help out with the improvement of Scala documentation. These include: | |||
|
|
|||
| * API Documentation in Scaladoc | |||
| * Code examples and tutorials in activator templates. | |||
There was a problem hiding this comment.
Anyway, this is the wrong place to suggest these changes. I think we're making suggestions for improving the getting started page, which is not the file we're commenting on (we're commenting on a contributing page)
|
I'm going to go ahead and merge this, and leave it to someone else to add stuff about |
|
on the subject of possible revisions to the getting-started page, I opened #536 (but I probably won't tackle it myself) |
and remove all mention of Activator from the site
(well, except from some old release announcements)