Skip to content

for local use, recommend Bundler and provide config #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 17, 2015

Conversation

SethTisue
Copy link
Member

so that people can test the site locally without having to
install stuff systemwide on their local machines

based on an earlier version originally contributed by Simon Ochsenreither
as part of a larger PR

the choice of Jekyll 1.5.1, for now, is based on Fabien's comments at
#361

@SethTisue
Copy link
Member Author

this is not yet ready for merge. @fsalvi, @heathermiller, can you help me make any needed further changes?

as already discussed at #361, the Gemfile now specifies Jekyll 1.5.1, which is the Jekyll version now in use in production. and I no longer exclude vendor in _config.yml, since Fabien reports that was interfering with resources/js/vendor (and we can't be more specific for now because of jekyll/jekyll#1915)

but the Gemfile.lock in this PR only mentions maruku, not kramdown, and at 361 @fsalvi says kramdown is the one we're using in production. where do I look on chara (or on webserver-production, do I need access to that?) to see what you did to the production setup there, so I can try to update this PR to match it?

@SethTisue
Copy link
Member Author

I see from https://scala-webapps.epfl.ch/jenkins/job/production_scala-lang.org-builder/371/console that it's webserver-production, not chara, that I would need to look at, but I don't have a login there.

@fsalvi
Copy link
Contributor

fsalvi commented Dec 17, 2015

Yes, it's not on chara but on another server.
It shouldn't be hard to reproduce the config, here's the list of gems:

*** LOCAL GEMS ***

blankslate (2.1.2.4)
classifier (1.3.4)
colorator (0.1)
commander (4.1.6)
fast-stemmer (1.0.2)
ffi (1.9.10)
highline (1.6.21)
jekyll (1.5.1)
json (1.8.3)
kramdown (1.8.0)
liquid (2.6.3, 2.5.5)
listen (1.3.1)
maruku (0.7.0)
mercenary (0.3.5)
parslet (1.5.0)
posix-spawn (0.3.11)
pygments.rb (0.6.3, 0.5.4)
rb-fsevent (0.9.5)
rb-inotify (0.9.5)
rb-kqueue (0.2.4)
redcarpet (2.3.0)
safe_yaml (1.0.4)
toml (0.1.2)
yajl-ruby (1.2.1, 1.1.0)

setting a GEM_HOME to a specific path and install jekyll (gem install jekyll -v 1.5.1) should be enough...

@fsalvi
Copy link
Contributor

fsalvi commented Dec 17, 2015

And I changed _config.yml to set the default renderer as Kramdown:
8134b48

@fsalvi
Copy link
Contributor

fsalvi commented Dec 17, 2015

I tried to build the website with your modifications (using the webserver config) and it looks good for me, the build output is ok.

so that people can test the site locally without having to
install stuff systemwide on their local machines

based on an earlier version originally contributed by Simon Ochsenreither
as part of a larger PR

the choice of Jekyll 1.5.1, for now, is based on Fabien's comments at
scala#361

particular version numbers for other gems are from Fabien's comment
at scala#373 (comment)
@SethTisue
Copy link
Member Author

great! I tweaked the Gemfile/Gemfile.lock according to the information you provided, squashed, and pushed. thanks — delighted to have this resolved.

SethTisue added a commit that referenced this pull request Dec 17, 2015
for local use, recommend Bundler and provide config
@SethTisue SethTisue merged commit 975fc12 into scala:master Dec 17, 2015
@SethTisue SethTisue deleted the add-gemfile-try-2 branch December 17, 2015 14:29
@heathermiller
Copy link
Member

I had some suggestions before merging this...


OSX users might have to update RubyGems:
cd into the directory where you cloned this repository, then install the required gems with `bundle install`. This will automatically put the gems into `./vendor/bundle`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make 2 sets of instructions. Those for without bundler (most people I'm surrounded by) and for those who wish to build with bundler.
Arguably lots of people either already have Jekyll installed system-wide on their machine or don't mind installing it system-wide.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lots of people either already have Jekyll installed system-wide on their machine

I believe the vast majority of people who have Jekyll on their machines have a modern version such as Jekyll 2 or Jekyll 3.

@heathermiller
Copy link
Member

Can you please do the above?

@SethTisue
Copy link
Member Author

I had to fix up the vendor directory situation in 66c5785

@SethTisue
Copy link
Member Author

Can you please do the above?

sure, working on it.

@SethTisue
Copy link
Member Author

see #375

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants