-
Notifications
You must be signed in to change notification settings - Fork 325
for local use, recommend Bundler and provide config #373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
this is not yet ready for merge. @fsalvi, @heathermiller, can you help me make any needed further changes? as already discussed at #361, the Gemfile now specifies Jekyll 1.5.1, which is the Jekyll version now in use in production. and I no longer exclude but the Gemfile.lock in this PR only mentions maruku, not kramdown, and at 361 @fsalvi says kramdown is the one we're using in production. where do I look on chara (or on webserver-production, do I need access to that?) to see what you did to the production setup there, so I can try to update this PR to match it? |
I see from https://scala-webapps.epfl.ch/jenkins/job/production_scala-lang.org-builder/371/console that it's webserver-production, not chara, that I would need to look at, but I don't have a login there. |
Yes, it's not on chara but on another server. *** LOCAL GEMS *** blankslate (2.1.2.4) setting a GEM_HOME to a specific path and install jekyll (gem install jekyll -v 1.5.1) should be enough... |
And I changed _config.yml to set the default renderer as Kramdown: |
I tried to build the website with your modifications (using the webserver config) and it looks good for me, the build output is ok. |
so that people can test the site locally without having to install stuff systemwide on their local machines based on an earlier version originally contributed by Simon Ochsenreither as part of a larger PR the choice of Jekyll 1.5.1, for now, is based on Fabien's comments at scala#361 particular version numbers for other gems are from Fabien's comment at scala#373 (comment)
dbf6e73
to
fcff4ce
Compare
great! I tweaked the Gemfile/Gemfile.lock according to the information you provided, squashed, and pushed. thanks — delighted to have this resolved. |
for local use, recommend Bundler and provide config
I had some suggestions before merging this... |
|
||
OSX users might have to update RubyGems: | ||
cd into the directory where you cloned this repository, then install the required gems with `bundle install`. This will automatically put the gems into `./vendor/bundle`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make 2 sets of instructions. Those for without bundler (most people I'm surrounded by) and for those who wish to build with bundler.
Arguably lots of people either already have Jekyll installed system-wide on their machine or don't mind installing it system-wide.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lots of people either already have Jekyll installed system-wide on their machine
I believe the vast majority of people who have Jekyll on their machines have a modern version such as Jekyll 2 or Jekyll 3.
Can you please do the above? |
I had to fix up the |
sure, working on it. |
see #375 |
so that people can test the site locally without having to
install stuff systemwide on their local machines
based on an earlier version originally contributed by Simon Ochsenreither
as part of a larger PR
the choice of Jekyll 1.5.1, for now, is based on Fabien's comments at
#361