Add carousel of code snippets to front page #1462
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
these are only visible with javascript enabled, which will inject hljs dark theme.
sjrd
approved these changes
Jan 31, 2023
bishabosha
force-pushed
the
add-code-carousel
branch
from
5527762 to
e9e2763
Compare
bishabosha
force-pushed
the
add-code-carousel
branch
from
e9e2763 to
221c8be
Compare
julienrf
reviewed
Feb 1, 2023
julienrf
approved these changes
Feb 1, 2023
|
added a compact view for buttons that expands on narrow screens: |
julienrf
approved these changes
Feb 1, 2023
|
trying a different header colour: |
bishabosha
force-pushed
the
add-code-carousel
branch
from
8a1c702 to
26f0013
Compare
|
Let's merge this. It seems like a definite improvement over the status quo. We can always further iterate later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea here is to add a carousel that is immediately visible. Each slide comes with a title, code snippet, Scastie link, and summary. it can be operated without JS on, but when JS is on then it changes slides every 8 seconds, until the user interacts with the carousel, which cancels the timer.
Also added a dark mode theme for code on the front page.
Also tag @romanowski @Kordyjan for review