Skip to content

Fix Docker setup #1239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 10, 2021
Merged

Fix Docker setup #1239

merged 1 commit into from
May 10, 2021

Conversation

julienrf
Copy link
Contributor

The Docker setup was not working for me, most probably because it was not using a specific version of the jekyll image, and maybe the latest images have broken something?

This PR introduces our own Dockerfile, which uses the same version of ruby as on the CI (2.5), and installs Jekyll from there. When this Docker image is built, the website dependencies are fetched and cached (ie, we run bundle install during the Docker image build time).

@julienrf julienrf requested a review from vincenzobaz May 10, 2021 08:44
@julienrf julienrf force-pushed the fix/docker-setup branch from 44f7164 to 6d9488e Compare May 10, 2021 09:33
@julienrf
Copy link
Contributor Author

@vincenzobaz I’ve simplified the Dockerfile according to your advice, and I’ve also updated the README and removed unused (I think) files.

Copy link
Member

@adpi2 adpi2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @julienrf it's been easier for me to make the site work with this docker setup.

It seems the docker-compose config in https://github.com/scala/docs.scala-lang is different. So which one is best?

@julienrf
Copy link
Contributor Author

julienrf commented May 10, 2021

It seems the docker-compose config in https://github.com/scala/docs.scala-lang is different. So which one is best?

Good point. Vincenzo also raised this point. We should probably try to unify them. On my side, my experience with docs.scala-lang.org was that I was unable to get incremental rendering work properly (basically it takes 1min30 to re-generate the website every time I change something, whereas in this PR the scala-lang.org website takes a couple of seconds to re-generate). What is your experience?

Copy link
Member

@adpi2 adpi2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have the same experience than you with docs.scala-lang: incremental build does not seem to work at all. It would be way better with the setup of this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants