Skip to content

Scala 2 Download Page's "Download IntelliJ" and "Download SBT" links are broken #1285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
s5bug opened this issue Oct 26, 2021 · 3 comments · Fixed by #1286 or #1294
Closed

Scala 2 Download Page's "Download IntelliJ" and "Download SBT" links are broken #1285

s5bug opened this issue Oct 26, 2021 · 3 comments · Fixed by #1286 or #1294

Comments

@s5bug
Copy link
Contributor

s5bug commented Oct 26, 2021

https://www.scala-lang.org/download/scala2.html (archive: https://web.archive.org/web/20210813043859/https://www.scala-lang.org/download/scala2.html)

The buttons for "Download IntelliJ" and "Download SBT" have broken hrefs, with no actual link value.

@julienrf
Copy link
Contributor

Hey, thank you for reporting. Indeed, the href was populated by some JavaScript code, and it was probably broken by commit e13f56a.

@s5bug would you be interested in fixing the issue?

@s5bug
Copy link
Contributor Author

s5bug commented Oct 26, 2021

I would! I don't know what the links are supposed to be, however.

@julienrf
Copy link
Contributor

According to the diff, the URL for IntelliJ was filled by this part of the HTML file:
e13f56a#diff-48fcde8b8ca3259f9707b78dc62f9257cbf5eb5644f065f20a7a6ffe7d53b9d2L114

But it points to this:

intellijUrls:
- os: linux
url: https://www.jetbrains.com/idea
- os: unix
url: https://www.jetbrains.com/idea
- os: macos
url: https://www.jetbrains.com/idea
- os: windows
url: https://www.jetbrains.com/idea

(all the entries have the same value!)
So, it seems simpler to just inline the URL in the href attribute.

s5bug added a commit to s5bug/scala-lang that referenced this issue Oct 26, 2021
s5bug added a commit to s5bug/scala-lang that referenced this issue Nov 5, 2021
This should fix scala#1285 for good. In scala#1286, it was unbeknownst to me that there was JS that ended up editing the HREFs of the IntelliJ and SBT links, and so the code that was initially broken there remained broken.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants