Standardize on sbt-extras #194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're still downloading the sbt-launch.jar for a couple of jobs that rely on it being available on the file system for full control TODO: rework those scripts to use sbt from sbt-extras
dwijnand
reviewed
Oct 21, 2016
| @@ -22,10 +22,8 @@ | |||
|
|
|||
| default['s3']['downloads']['host'] = "downloads.typesafe.com.s3.amazonaws.com" | |||
|
|
|||
| # work around https://github.com/gildegoma/chef-sbt-extras/issues/33 by overriding the URL we get | |||
| # the sbt launch script from. latest version as of 9 Sep 2015 | |||
| # sbt is used by Scabot and by the dotty build, and in some glorious future, the scala build too | |||
There was a problem hiding this comment.
we're living in the glorious future, huzzah! 🎉
seems fine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're still downloading the sbt-launch.jar for a couple of jobs
that rely on it being available on the file system for full control
TODO: rework those scripts to use sbt from sbt-extras
running in prod on master and ubuntu workers -- @SethTisue, could you keep an eye on the windows one?