Another round of renaming / preparing for open-source release #5
Conversation
|
Review by @gkossakowski @adriaanm @adriaanm Can you please create a team for this repo and add the Akka guys as collaborators? Alternatively, we can merge this PR and make the repo public. |
"org.scala-lang.modules" %% "scala-compat-jdk8" import scala.compat.jdk8._ Subsequent commits will address the under-loved `JFunc`.
In accordance with the move to the Scala github organization and the plan to release this under "org.scala-lang.modules".
So as to avoid the inconsistent abbreviation with `JFunctionN`.
- add the scala-modules SBT plugin
- configure OSGi package export
- Check that SBT is running on Java8, rather than waiting for
cryptic build errors.
- convert `LambdaTest` to a JUnit test.
|
I'm now undecided between |
Are we there yet?
|
In either case, we need to rename the repo when we merge this PR. |
|
I prefer the former as well. Reading aloud: "scala-java8-compat" and "scala-compat-java8" helps to make one's mind. The former is easier to talk about. |
|
Yes, github supports (only once per repo) renames though. |
|
The argument in favor of |
|
I think I've convinced myself that having it around backwards actually correct because package names are reversed anyway; people say |
"It" refers to module name here? |
|
Yep, "having the segments of module name and package names reversed". |
|
The overall diff LGTM. Let's squash some of the commits that amend other commits in this PR and we are ready to go. If it's too much work to squash commits then feel free to merge as is. |
|
This one will be fiddly to rebase (references to names in docs, build etc are hard to catch to be sure each step is consistent.) So I think I'll take the free pass on this one. |
Another round of renaming / preparing for open-source release
| scalaVersion := "2.10.3" | ||
| import com.typesafe.tools.mima.plugin.{MimaPlugin, MimaKeys} | ||
|
|
||
| scalaModuleSettings |
Details in the commits.