use before_script to trigger Travis CI jobs #650
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the instruction was to use ``` before_install: export SCALA_VER_BASE=$SCALA_VER_BASE SCALA_VER_SUFFIX=$SCALA_VER_SUFFIX ``` to manually trigger Travis CI jobs. However since scala/scala@8f7fdc4 we started using `before_install` phase to install AdoptOpenJDK so we can't hijack it to set the variables. `before_script` is currently ununsed, so that's safe to use.
|
fyi @szeiger, I guess you'll hit this when you build 2.13.1. I've updated the 2.12.10 ticket accordingly |
|
I've already manually edited #645 for scala/scala (scala/scala-dist doesn't really matter for now). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the instruction was to use
to manually trigger Travis CI jobs.
However since scala/scala@8f7fdc4 we started using
before_installphase to install AdoptOpenJDK so we can't hijack it to set the variables.before_scriptis currently ununsed, so that's safe to use.