Skip to content

Test failure on JDK 17 #790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SethTisue opened this issue Sep 29, 2021 · 7 comments
Closed

Test failure on JDK 17 #790

SethTisue opened this issue Sep 29, 2021 · 7 comments
Assignees

Comments

@SethTisue
Copy link
Member

https://github.com/scala/scala/runs/3739318271 shows

!!  931 - run/t2318.scala                           [output differs]
% diff D:\a\scala\scala\test\files\run\t2318.check D:\a\scala\scala\test\files\run\t2318-run.log--- t2318.check
+++ t2318-run.log
@@ -1,1 +1,2 @@
+warning: two deprecations; re-run with -deprecation for details
 bar
##### Log file 'D:\a\scala\scala\test\files\run\t2318-run.log' from failed test #####

warning: two deprecations; re-run with -deprecation for details
bar
bar
@SethTisue SethTisue self-assigned this Sep 29, 2021
SethTisue added a commit to SethTisue/scala that referenced this issue Sep 29, 2021
@som-snytt
Copy link

It's already besprinkled.

// SecurityManager is deprecated on JDK 17, so we sprinkle @deprecated around

Also, filtered

// java: -Ddummy=fresh_jvm_needed_to_test_security_manager
// filter: WARNING.*
// for now, ignore warnings due to reflective invocation

@SethTisue
Copy link
Member Author

SethTisue commented Sep 29, 2021

My new PR is for 2.12. But yes, I forgot that already included a version of this in the 2.13 PR scala/scala#9677

@SethTisue
Copy link
Member Author

I'll update the PR so that 2.12 does it exactly the way 2.13 does, to reduce future merge conflicts. Thanks for the heads up.

@lrytz
Copy link
Member

lrytz commented Sep 30, 2021

@joroKr21 joroKr21 closed this in [fbb7794](/joroKr21/scala/commit/fbb77949a9f4522452bbd5f3cb5e0d568e75ffe3) 1 hour ago

interesting github feature...

@som-snytt
Copy link

I've also been bitten by github features. Because you gave me the power.

@joroKr21
Copy link
Member

I guess the difference is that I haven't changed the default branch in my fork to 2.13 🤔

@som-snytt
Copy link

I don't remember -- insert comic panel -- maybe I accidentally closed a ticket while pushing to my own branch?

I hope the SF Giants go deep enough into the post-season so Brandon Belt can return from his thumb fracture. And I wish San Diego Padres weren't terrible so LA Dodgers could win on the merits.

I also have many hopes for Scala and coding and our world and the people in it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants