Skip to content

Travis-CI failing because AdoptOpenJDK disappeared from sdk list java #788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
SethTisue opened this issue Sep 20, 2021 · 2 comments · Fixed by #789
Closed

Travis-CI failing because AdoptOpenJDK disappeared from sdk list java #788

SethTisue opened this issue Sep 20, 2021 · 2 comments · Fixed by #789
Assignees
@SethTisue

Comments

@SethTisue
Copy link
Member

seen at e.g. scala/scala#9763

not sure if we should hope that it's a transient problem that will correct itself, or switch to Zulu (or whatever), or what
@SethTisue SethTisue self-assigned this Sep 20, 2021
@SethTisue SethTisue mentioned this issue Sep 20, 2021
Merged
@SethTisue
Copy link
Member Author

SethTisue commented Sep 20, 2021 •
edited
Loading

the place to report this upstream would be https://github.com/sdkman/sdkman-db-migrations/issues see below

@SethTisue
Copy link
Member Author

I suppose this has to do with https://blog.adoptopenjdk.net/2021/08/goodbye-adoptopenjdk-hello-adoptium/ and we should now be using Temurin instead

sdk list java has:

 Temurin       |     | 16.0.2       | tem     |            | 16.0.2-tem          
               |     | 11.0.12      | tem     |            | 11.0.12-tem         
               |     | 8.0.302      | tem     |            | 8.0.302-tem

with 17 being worked on, I'm sure

@SethTisue SethTisue mentioned this issue Sep 20, 2021
Merged
SethTisue added a commit to SethTisue/scala-dev that referenced this issue Sep 20, 2021
@SethTisue
bye bye AdoptOpenJDK hello Temurin
0967b22 
fixes scala#788
SethTisue added a commit to SethTisue/scala that referenced this issue Sep 21, 2021
@SethTisue
test on JDK 18-ea
94a1f86 
it's not clear what we "ought" to do here. SDKMAN dropped
17 early access builds (scala/scala-dev#788), but
Temurin (aka Adoptium/AdoptOpenJDK) 17 isn't available yet.

we could use a Zulu or Java.net build, but I suggest we simply
start testing on 18 instead, for now anyway. once Temurin 17
is out we could consider also adding it
@SethTisue SethTisue mentioned this issue Sep 21, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SethTisue SethTisue

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bye bye AdoptOpenJDK hello Temurin SethTisue/scala-dev
1 participant
@SethTisue