PR validation has been failing (for some weeks) since Scalariform switched from maven to sbt #71
Comments
SethTisue
changed the title
|
@sschaef writes:
|
|
@sschaef the relevant scripts that may need updating are https://github.com/scala-ide/uber-build/blob/master/uber-build.sh and possibly https://github.com/scala/scala/blob/2.11.x/scripts/jobs/integrate/ide
scripts/jobs/integrate/ide receives the right sbt command to use in the to make local testing easier, in scripts we typically write |
|
Alright, I'm going to try that out. |
|
So that Scala PR validation doesn't remain affected, and so there won't be any huge rush on a fix, I'm going to temporarily remove |
should be reinstated once the ScalaIDE folks have tackled scala/scala-dev#71
should be reinstated once the ScalaIDE folks have tackled scala/scala-dev#71
|
@sschaef I guess this involves the uber-build, and there's a validator configuration especially for this purpose. I guess that one should pass locally before you need to test it on Jenkins. Because of these hidden dependencies I'm always wary of build changes, so if this is too much I'd say we go back to maven. Neither refactoring nor scalariform have complicated builds, so the pain will quickly outweight any benefits. |
|
Yeah, for the next time I'll remember this. The good side of it is that I understand the build chain better every time better when something breaks. |
|
one possible consideration: the Scala community build expects sbt. (uh, well maybe dbuild has some maven support? even if it does, I doubt it's actively maintained) |
|
@sschaef did you manage to track down the regression? It may be difficult to turn the validation back on, since regressions may creep into Scala |
|
Yes it is nearly fixed. I'm going to fix it completely probably today or tomorrow. |
|
@SethTisue I fixed the 2.11.x build locally. I can upload my changes but first I would like to understand how exactly scala-ide gets the Scala dependency. Could you show me how the script of this Jenkins job https://scala-ci.typesafe.com/job/scala-2.11.x-integrate-ide/ runs uber-build? |
|
I guess you figured it out and no longer have a question? but I'll answer anyway, there is a one-to-one correspondence between Jenkins job names and files in |
|
Thanks, that is helpful. I already did a test run but it failed at some other point. Still takes me a little bit longer. |
|
The sbt build works now but it can't find the Scala dependency: https://scala-ci.typesafe.com/job/scala-2.11.x-integrate-ide/2028/console Maybe the dependency is already gone. Are the Scala dependencies cached or are they removed after a build has been finished? |
|
@sschaef In that failure log, I don't see sbt looking for the Scala artifacts where it should be, namely on https://scala-ci.typesafe.com/artifactory/scala-pr-validation-snapshots/ (where they are archived indefinitely afaik) Note that when the integrate/ide script runs uber-build.sh, it sets both |
|
Oh, you are right. I completely oversaw this part. In that case I only have to add them through a resolver. |
|
Scala 2.11.x CI is back on green: https://scala-ci.typesafe.com/job/scala-2.11.x-integrate-ide/2034/ Nevertheless, I had to disable two tests because they fail on Scala Jenkins but not on Scala IDE Jenkins. I'm going to look into that next week. If in the next days I can't find out why the tests are failing, we can let them on ignored status and reactivate scala-ide integration in order to avoid potential breaking changes. |
…main" This reverts commit 46b6aa1. at scala/scala-dev#71 , @sschaef says the coast should be clear now
|
I re-added |
|
In order to be more safe in future, would you please add me to the email notifications about failed builds on the scala-2.11.x-integrate-ide job? I don't have permissions to add myself. The email is [email protected] |
I don't have manager rights on https://groups.google.com/a/typesafe.com/forum/#!forum/pr-scala-integrate-ide, but I believe @dragos does |
|
Haha, that is cool. I didn't know the Scala Jenkins works so differently to the Scala IDE Jenkins. Even more interesting is that so many things can be plugged into Jenkins. Some kind of powerful software. |
|
|
On 01/22/2016 07:22 PM, Iulian Dragos wrote:
|
and Scalariform is part of https://github.com/scala-ide/uber-build
example failure: https://scala-ci.typesafe.com/job/scala-2.11.x-integrate-ide/2026/console
The text was updated successfully, but these errors were encountered: