Skip to content

Release 2.12.8 #582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
47 tasks done
lrytz opened this issue Nov 15, 2018 · 12 comments
Closed
47 tasks done

Release 2.12.8 #582

lrytz opened this issue Nov 15, 2018 · 12 comments
Assignees

Comments

@lrytz
Copy link
Member

lrytz commented Nov 15, 2018

SCALA_SHA=38cd84d976880eab16af17a44d186bbddcd554f2
DIST_SHA=d8cf4f730a6d50411ea59a5e0df4e1f651255d48

Key links:

N weeks before the release

  • Wind down PR queue. There has to be enough time after the last (non-trivial) PR is merged and the next phase. The core of the eco-system needs time to prepare for the final!
  • Triage scala/bug and scala/scala-dev tickets
  • Create next scala/scala milestone
  • Close the scala/bug milestone, create next milestone, move pending issues
  • Close the scala/scala-dev milestone, create next milestone, move pending issues
  • Check PRs assigned to the milestone, also check WIP
  • Announce expected release date and current nightly "release candidate" (nightly sha-mangled version) at https://scala-ci.typesafe.com/artifactory/scala-integration/ on https://contributors.scala-lang.org/c/announcements

Release announcement / notes

  • Notify community on https://contributors.scala-lang.org/c/announcements
  • Review merged PRs, make sure release-notes label is applied appropriately
  • PRs with release-notes label must have excellent title & description (title will be pasted literally in release note bullet list)
  • Draft release notes (to be published once GitHub tag is pushed)
    • note that GitHub release notes drafts can only be viewed by committers, so use a gist to draft the notes, so the gist can be shared with the community
  • On contributors thread, link to release note gist and request feedback
  • Prepare PR to https://github.com/scala/scala-lang/ (using scala/make-release-notes which requires a staged release and a pushed tag)
    • documentation/api.md
    • download/index.md
    • _config.yml (update devscalaversion or scalaversion)

N days before release

  • Announce no more PRs will be merged unless last-minute regressions are found. Re-iterate current nightly sha version for testing.
  • Community build: Release 2.12.8 #582 (comment)
  • Windows Jenkins job
  • Check any merged PRs accidentally assigned to the next milestone in this branch, and re-assign them to this milestone
  • Merge in any older release branch
  • Check module versioning (is everything in versions.properties up to date?)

Point of no return

Check availability

When everything is on maven central

Modules

  • if it's a 2.12.x release, publish macro paradise for the new version

Announcements

Afterwards

  • Create PR to update versions.properties (new file generated by the bootstrap job) and the baseVersion in build.sbt
@lrytz lrytz self-assigned this Nov 15, 2018
@SethTisue
Copy link
Member

I bumped the community build Scala SHA just now (scala/community-build@ac02adb) and triggered a fresh run at https://scala-ci.typesafe.com/view/scala-2.12.x/job/scala-2.12.x-integrate-community-build/

@SethTisue
Copy link
Member

I (provisionally) closed the 2.12.8 milestone and made new 2.12.x PRs target 2.12.9.

@SethTisue
Copy link
Member

Community build is green on 2.12.8-bin-25c7215

@SethTisue
Copy link
Member

@lrytz we might want to wait for a reply from @japgolly at scala/bug#11174

@SethTisue
Copy link
Member

SethTisue commented Nov 28, 2018

community build run on 2.12.8-bin-38cd84d: https://scala-ci.typesafe.com/view/scala-2.12.x/job/scala-2.12.x-integrate-community-build/3821/

UPDATE: it went green in run 3823

@lrytz
Copy link
Member Author

lrytz commented Dec 3, 2018

I'm planning to run the release scripts on 38cd84d tomorrow.

@SethTisue
Copy link
Member

did you make a decision about backporting scala/scala#7438 ?

@lrytz
Copy link
Member Author

lrytz commented Dec 3, 2018

I think 2.12.9 is fine, it's an old bug after all (since 2.12.0)

@lrytz
Copy link
Member Author

lrytz commented Dec 4, 2018

Beh, travis failed with java.io.IOException: PUT operation to URL https://oss.sonatype.org/service/local/staging/deploy/maven2/org/scala-lang/scala-library-all/2.12.8/scala-library-all-2.12.8.pom failed with status code 504: Gateway Time-out.

I think at this stage I can just re-try, nothing has been published / uploaded except for the artifacts in the staging repo, which I can drop.

EDIT: rebuild worked.

@SethTisue
Copy link
Member

@lrytz shouldn't the release notes mention the license change to Apache 2?

@SethTisue
Copy link
Member

@lrytz also scala/scala-lang#958 can be merged at the time you redo scala/scala-lang#980

@SethTisue
Copy link
Member

come to think of it, the license change is also important enough to mention in the blog post

@lrytz lrytz closed this as completed Dec 6, 2018
@eed3si9n eed3si9n mentioned this issue Jul 20, 2019
58 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants