Skip to content
This repository was archived by the owner on Jun 23, 2020. It is now read-only.

Clean up the build #31

Merged
merged 1 commit into from
Apr 21, 2017
Merged

Clean up the build #31

merged 1 commit into from
Apr 21, 2017

Conversation

lrytz
Copy link
Member

@lrytz lrytz commented Apr 20, 2017

  • Update the sbt version
  • Update scala-module-plugin
  • Remove the explicit sbt-mima-plugin dependency, as it's provided
    via scala-module-plugin.
  • Apply commonSettings before custom project settings to allow
    overrides
  • Set mimaPreviousVersion, the rest of the mima config is done by the
    scala-module-plugin
  • Define scalaVersionsByJvm
  • Remove snapshotScalaBinaryVersion, there are no more Scala snapshots

@lrytz
Copy link
Member Author

lrytz commented Apr 20, 2017

This will fail validation because the updated scala-module-plugin (1.0.6) is not yet available, just submitting it to make sure we don't duplicate work.

- Update the sbt version
- Update scala-module-plugin
- Remove the explicit sbt-mima-plugin dependency, as it's provided
  via scala-module-plugin.
- Apply `commonSettings` before custom project settings to allow
  overrides
- Set `mimaPreviousVersion`, the rest of the mima config is done by the
  scala-module-plugin
- Define `scalaVersionsByJvm`
- Remove `snapshotScalaBinaryVersion`, there are no more Scala snapshots
@danslapman
Copy link
Contributor

Thank You, Lukas! Waiting for 1.0.6

@lrytz
Copy link
Member Author

lrytz commented Apr 21, 2017

I just released 1.0.6 and re-started the travis build here.

@lrytz lrytz changed the title Clean up the build [WIP] Clean up the build Apr 21, 2017
@danslapman
Copy link
Contributor

Great!

@danslapman danslapman merged commit 2ea768a into scala:master Apr 21, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants