Skip to content
This repository was archived by the owner on Jun 23, 2020. It is now read-only.

Cross-compilation with 2.12.0 #12

Merged
merged 10 commits into from
Jun 8, 2016
Merged

Cross-compilation with 2.12.0 #12

merged 10 commits into from
Jun 8, 2016

Conversation

danslapman
Copy link
Contributor

Hello!
This PR adds cross-compilation with 2.12 scala series. I want this plugin to be alive :)

@danslapman
Copy link
Contributor Author

@adriaanm compilation with actual sbt (0.13.11) fails in Travis. Maybe drop jdk6 check or compile against openjdk7?

@adriaanm
Copy link
Contributor

adriaanm commented Jun 1, 2016

Thanks for the life support 👍 !

*** buffer overflow detected ***: /usr/lib/jvm/java-6-openjdk-amd64/bin/java terminated 🐳

wow -- hadn't seen that one yet! we could just run everything on jdk 8 I guess?

@danslapman
Copy link
Contributor Author

Just excluded JDK6 from Travis build - now all seems fine.

@danslapman
Copy link
Contributor Author

@adriaanm what else I need to get continuations build for 2.12?)

@adriaanm
Copy link
Contributor

adriaanm commented Jun 3, 2016

What do you mean exactly? It seems like they build ok against M4 now that you added it.

@danslapman
Copy link
Contributor Author

I mean any chance it will be shipped with scala 2.12.x series?

@adriaanm
Copy link
Contributor

adriaanm commented Jun 5, 2016

No, but we'll be happy to keep it going in its own repo

@adriaanm
Copy link
Contributor

adriaanm commented Jun 6, 2016

(The same is true for the other modules -- we don't intend to add to the core distribution, but instead make it easier to discover and add modules to your project.)

@danslapman
Copy link
Contributor Author

danslapman commented Jun 6, 2016

@adriaanm oh, I did not mean to merge scala-continuations in core distribution. I mean, will scala-continuations be published to maven? The reason I messed with cross-building (and opening this PR) is I use it in some production code, It's ok for me to maintain it further, but I want to figure out if I need to publish artifacts by my own, or it will be published under 'scala/scala-continuations' as before.

@adriaanm
Copy link
Contributor

adriaanm commented Jun 6, 2016

Sure, if you or someone else steps up to become a maintainer, publishing it to maven is a matter of a few keystrokes on our end. Published artifacts imply a promise of future ones, so as long as we have that potential, I'm okay publishing to maven.

@adriaanm
Copy link
Contributor

adriaanm commented Jun 6, 2016

To publish 2.11 a release, we do need to run on jdk6, though. (Compiling on jdk8 could introduce dependencies on methods not there in jdk6.)

@danslapman
Copy link
Contributor Author

OK, then i will investigate the reason why jdk6 build fails.

@danslapman
Copy link
Contributor Author

@adriaanm fixed! Now all builds fine under jdk6 :)
I'm ready to maintain this project futher, can You please change "unsupported" status of this project and mention me as a maintainer?

@adriaanm
Copy link
Contributor

adriaanm commented Jun 8, 2016

Gladly!

On Wednesday, June 8, 2016, danslapman [email protected] wrote:

@adriaanm https://github.com/adriaanm fixed! Now all builds fine under
jdk6 :)
I'm ready to maintain this project futher, can You please change
"unsupported" status of this project and mention me as a maintainer?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#12 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAFjyyuZtsFaXR1sfwN6bXU9SrJaYo5Mks5qJrpDgaJpZM4Iq0ma
.

@adriaanm adriaanm merged commit 739ee98 into scala:master Jun 8, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants