-
Notifications
You must be signed in to change notification settings - Fork 32
Iterator.takeUntilException #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Maybe it would be worth to implement the 1st in terms of the 2nd? Something like this:
|
Done. |
Please let me know if there are more ideas for improving this PR. |
I re-opened the PR to force a rebuild in Travis. |
Travis fails to install a JDK. Note that the last commit only touched a scaladoc line. Before that commit the Travis build did succeed. I would appreciate it if this PR got merged. The longer this stays open, the more work there is to maintain it. |
Looking at the CI output, the problem does not seem to come from this PR: https://travis-ci.org/scala/scala-collection-contrib/jobs/608709711?utm_medium=notification&utm_source=github_status |
There. That last commit fixes the Travis problem. |
needs rebase, after #70 |
@SethTisue I will gladly do that if someone tells me she/he is willing to merge this pr. |
seems mergeable to me, wdyt @julienrf? |
Yes, let’s merge it! Thanks @erikvanoosten for your patience! |
# Conflicts: # .travis.yml
@julienrf Its mergeable again :) |
Thanks @erikvanoosten! |
This introduces
Iterator.takeUntilException
, a method that can be useful in situations where you want to get as much out of an iterator as possible. For example, I used it to read records from a corrupted Avro file.