-
Notifications
You must be signed in to change notification settings - Fork 32
Documentation and tests for IteratorDecorator. #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I just realized that the correct term for things in a collection is |
Corrected order of arguments to assertEquals.
I completed docs and unit tests for I did not document
I'll work some more on this project in a new PR. |
Build fails. I had expected we could use |
I suggest that you copy their definitions from the standard library. https://github.com/scala/scala/blob/05d028e0eee1eaf9032e652395b94a124c6ad9ed/src/library/scala/collection/Iterator.scala#L50 |
src/main/scala/scala/collection/decorators/IteratorDecorator.scala
Outdated
Show resolved
Hide resolved
@@ -3,8 +3,39 @@ package decorators | |||
|
|||
import scala.annotation.tailrec | |||
|
|||
/** Enriches [[Iterator]] with additional methods. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be just Iterator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh.
Thanks a lot! Could you please squash the comits into a single one? |
Isn't squashing an option when you merge in github? If not, I can find out how to do that. |
Right, there is an option for that. |
If this is approved, I will add similar docs and tests for the other intersperse implementations.