Skip to content

Run the CI only on the right module #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 4, 2019
Merged

Run the CI only on the right module #45

merged 1 commit into from
Sep 4, 2019

Conversation

julienrf
Copy link
Collaborator

@julienrf julienrf commented Sep 3, 2019

We previously run the CI tasks on the root module, which aggregates
both the JS and JVM modules. This resulted in wasting CPU and
duplicating releases on Sonatype (see #43 (comment))

@julienrf
Copy link
Collaborator Author

julienrf commented Sep 3, 2019

I’m not sure this is the right way to fix the issue. Do we have a standardized solution across Scala modules for cross-publishing?

We previously run the CI tasks on the root module, which aggregates
both the JS and JVM modules. This resulted in wasting CPU and
duplicating releases on Sonatype (see #43 (comment))
@julienrf julienrf requested a review from SethTisue September 3, 2019 20:24
@julienrf julienrf merged commit 0cc5f30 into master Sep 4, 2019
@julienrf julienrf deleted the select-module-ci branch September 4, 2019 07:08
@SethTisue
Copy link
Member

Do we have a standardized solution across Scala modules for cross-publishing?

That's an evolving situation... scala-xml is usually the flagship, other modules tend to copy it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants