Skip to content

adapt to change in Scala 2.13.9 + Scala 3.2.1 #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 28, 2022

Conversation

SethTisue
Copy link
Member

@SethTisue SethTisue commented Jul 20, 2022

namely scala/scala#10047

this came up at scala/community-build#1579

not for merge until 2.13.9 is actually released and we can upgrade, so that compilation will succeed

in the meantime we can use the branch in the community build

@som-snytt
Copy link
Contributor

I expected this to work:

➜  ~ skala -Xsource:3
Welcome to Scala 2.13.9-20220720-072233-0771b75 (OpenJDK 64-Bit Server VM, Java 18.0.1.1).
Type in expressions for evaluation. Or try :help.

scala> class C { def f(sb: StringBuilder): sb.type = sb }
class C

scala> class D extends C { override def f(sb: StringBuilder) = sb }
                                        ^
       error: incompatible type in overriding
       def f(sb: StringBuilder): sb.type (defined in class C);
        found   : (sb: StringBuilder): StringBuilder
        required: (sb: StringBuilder): sb.type

@SethTisue
Copy link
Member Author

SethTisue commented Jul 20, 2022

closing for now, but I've set a private reminder to reopen after 2.13.9 2.13.10 is out.

@SethTisue SethTisue reopened this Oct 13, 2022
@SethTisue SethTisue self-assigned this Oct 13, 2022
@SethTisue
Copy link
Member Author

SethTisue commented Oct 13, 2022

now there is a new problem: Scala 3 hasn't taken the 2.13.9 or 2.13.10 upgrades yet

until that's resolved, we'd need version-specific sources in order to cross-compile

I think it's fine to just wait until there's a Scala 3 version available that has taken the upgrade

@SethTisue
Copy link
Member Author

2.13.10 upgrade PR is scala/scala3#16074 — I've been too busy with other things lately to attend to it, but it's near the top of my queue now

@SethTisue
Copy link
Member Author

I think it's fine to just wait until there's a Scala 3 version available that has taken the upgrade

3.2.1-RC4 took the upgrade, so we should be able to move to 3.2.1 soon

@SethTisue SethTisue changed the title adapt to change in Scala 2.13.9 adapt to change in Scala 2.13.9 + Scala 3.2.1 Oct 26, 2022
@SethTisue SethTisue force-pushed the scala-2.13.9 branch 2 times, most recently from db70ce1 to d7e0fe0 Compare October 27, 2022 17:35
includes a small tweak necessary in order to adapt to
scala/scala#10047

this originally came up at
scala/community-build#1579
@SethTisue SethTisue marked this pull request as ready for review October 28, 2022 09:46
@SethTisue SethTisue merged commit e04673b into scala:main Oct 28, 2022
@SethTisue SethTisue deleted the scala-2.13.9 branch October 28, 2022 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants