Rewrite immutable.Set/Map.+
#53
Conversation
…oad accepting multiple values
There was a problem hiding this comment.
Awesome @MasseGuillaume! Do you mind adding some more test cases like the following?
(set + (2, 3)).map(x => x)
set + (2, 3) - 4Do you see other possible corner cases?
| op, | ||
| Nil, | ||
| List(rhs2) | ||
| ).toString |
There was a problem hiding this comment.
What does toString do? That looks suspect 😄
There was a problem hiding this comment.
It's fine, it will drop any comments. It's the scope of https://github.com/scalacenter/scala-syntax
There was a problem hiding this comment.
I was wondering whether toString was the recommended way to produce scala source code from a tree or if there was a method with a more meaningful name.
There was a problem hiding this comment.
I create the structure I want, then I pretty print. I dont want to deal with parenthesis.
There was a problem hiding this comment.
Oh, I think it’s .syntax, right?
There was a problem hiding this comment.
exactly, I can use .syntax.
|
@julienrf I don't see any corner case. |
|
Thanks! |
The
+operation no longer has an overload accepting multiple valuesmotivation:
https://github.com/scala/collection-strawman/wiki/FAQ#what-are-the-breaking-changes
2nd row, breaking change