Add support for Scala 2.11 #5
Conversation
julienrf
force-pushed
the
more-scala-versions
branch
from
b0ffba4 to
757627d
Compare
julienrf
changed the title
|
not sure we should support 2.10. let's discuss further on the issue |
build.sbt
Outdated
|
|
||
| crossScalaVersions := Seq("2.12.4", "2.13.0-pre-c577876") | ||
| crossScalaVersions := Seq("2.10.7", "2.12.5", "2.11.12", "2.13.0-pre-c577876") |
There was a problem hiding this comment.
Let's start with 2.12.5 here to make it the default. I'm OK with keeping 2.10.7 (at the end of the list) for now but if we run into any 2.10-specific problems, the default should be to drop 2.10 support.
There was a problem hiding this comment.
I don't see any value in providing 2.10 support that might be dropped any time. I see negative value in this, in fact, as it leads potential users down a garden path of expecting continued 2.10 support.
There was a problem hiding this comment.
scalacheck is heavily depended on and it currently supports Scala 2.10. If we drop 2.10 support in the compat library, either scalacheck and all the projects that depend on it will have to drop 2.10 support, or we will have to copy the contents of the compat library in scalacheck.
julienrf
force-pushed
the
more-scala-versions
branch
from
dfb6681 to
7a33253
Compare
julienrf
force-pushed
the
more-scala-versions
branch
from
c9e0aa8 to
b33ea40
Compare
julienrf
changed the title
|
I’ve removed 2.10 support because some tests were failing due to a difference in type inference. |
- Remove extensibility framework (fixes scala#5) - Remove `ImmutableMapDecorator` and `MutableMapDecorator`, because `updatedWith` and `updateWith` have been merged upstream
Fixes #1
The only required change was that in
ImmutableArray’s implementation I had to inline a couple of methods that are defined in 2.12 but don’t exist in 2.11.