Skip to content

support for scala-native #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

MasseGuillaume
Copy link
Contributor

No description provided.

@MasseGuillaume MasseGuillaume force-pushed the scala-native branch 3 times, most recently from c10e1e9 to 3ed38d5 Compare June 19, 2018 12:48
currently fail to link:

> scala-collection-compatNative/test
[warn] MiMa will NOT run because no mimaPreviousVersion is provided.
[info] Linking (1002 ms)
[error] cannot link: @java.lang.Class::getField_java.lang.String_java.lang.reflect.Field
[error] cannot link: @java.lang.ClassLoader::loadClass_java.lang.String_java.lang.Class
[error] unable to link
[error] (scala-collection-compatNative/nativetest:nativeLink) unable to link
[error] Total time: 2 s, completed Jun 19, 2018 3:21:42 PM

We cannot use openjdk6 since maven central wont serve TLS1.0

Server access Error: Received fatal alert: protocol_version url=https://repo1.maven.org/maven2/org/scala-sbt/compiler-interface/0.13.17/compiler-interface-0.13.17.jar

see https://stackoverflow.com/a/50824799/449071
@MasseGuillaume
Copy link
Contributor Author

ping @densh

This library is a shim to cross-build between 2.11, 2.12 and 2.13.

It fails to link with the usual suspects:

> scala-collection-compatNative/test
[warn] MiMa will NOT run because no mimaPreviousVersion is provided.
[info] Linking (1002 ms)
[error] cannot link: @java.lang.Class::getField_java.lang.String_java.lang.reflect.Field
[error] cannot link: @java.lang.ClassLoader::loadClass_java.lang.String_java.lang.Class
[error] unable to link
[error] (scala-collection-compatNative/nativetest:nativeLink) unable to link
[error] Total time: 2 s, completed Jun 19, 2018 3:21:42 PM

I assume this is due to
https://github.com/scala/scala-collection-compat/blob/master/src/main/scala-2.11_2.12/scala/collection/compat/immutable/ArraySeq.scala#L33

@@ -1,60 +1,60 @@
package test.scala.collection

import org.junit.{Assert, Test}
import utest._
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is no junit for Scala-Native.

@sjrd
Copy link
Member

sjrd commented Jun 19, 2018

Introducing a dependency on uTest is very dangerous. First, it prevents uTest itself from ever using scala-collection-compat. But more critically, it will introduce further delay on the republishing of the ecosystem for new versions of Scala. Now virtually everyone is going to transitively wait on uTest.

It's cool that the migration of the tests was done to demonstrate that scala-collection-compat actually works with Scala Native. But given the downsides of that migration, I would advocate that, in the main build, the Scala Native version be only built and published, but not tested. We can keep a separate branch with the migrated tests, to be rebased every now and then to ensure Scala Native keeps working.

@MasseGuillaume
Copy link
Contributor Author

@sjrd makes sense, we should compile + link on native, right now ArraySeq won't link.

Eventually, a ScalaNativeJUnitPlugin would be useful.

@MasseGuillaume
Copy link
Contributor Author

related: scala-native/scala-native#1256

martijnhoekstra pushed a commit to martijnhoekstra/scala-collection-compat that referenced this pull request Nov 9, 2022
Run the CI only on the right module
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants