fix github url #39
Merged
fix github url #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you resolve the conflicts please? |
MasseGuillaume
force-pushed
the
fix-github-url
branch
from
0f4c134 to
1c0dfb7
Compare
per https://github.com/scalacenter/scalafix/blob/8490db2edf3ef9aa6291870c04e56fa37ce4537d/scalafix-reflect/src/main/scala/scalafix/internal/reflect/GitHubUrlRule.scala#L33 the url format is github:org/repo/version we use NewCollections as the version, but it get's lowercased
MasseGuillaume
force-pushed
the
fix-github-url
branch
from
1c0dfb7 to
3923a8b
Compare
|
@julienrf done, ready to merge. |
martijnhoekstra
pushed a commit
to martijnhoekstra/scala-collection-compat
that referenced
this pull request
Nov 9, 2022
Use AdoptOpenJDK JDK 8 and 11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a bug introduced in:
d63d4ea#diff-04c6e90faac2675aa89e2176d2eec7d8R49
per
https://github.com/scalacenter/scalafix/blob/8490db2edf3ef9aa6291870c04e56fa37ce4537d/scalafix-reflect/src/main/scala/scalafix/internal/reflect/GitHubUrlRule.scala#L33
the url format is github:org/repo/version
we use NewCollections as the version, but it get's lowercased
gives me
workaround