Rule for symbolic foldLeft(/:) and foldRight(:/) (fix #27) #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienrf
approved these changes
Jun 11, 2018
MasseGuillaume
commented
Jun 11, 2018
| def replaceSymbolicFold(ctx: RuleCtx) = | ||
| ctx.tree.collect { | ||
| case Term.Apply(ap @ Term.ApplyInfix(rhs, foldRightSymbol(_), _, List(lhs)), _) => | ||
| ctx.replaceTree(ap, s"$rhs.foldRight($lhs)") |
There was a problem hiding this comment.
@julienrf this would remove formatting and delete comments inside the parenthesis of the infix apply.
ex:
/*1*/(/*2*/ 0 /*3*/ /: /*4*/ xs /*5*/)/*6*/(f)/*1*/xs.foldLeft(0)/*6*/(f)the best we can achieve is to preserve one side, since this refactoring swap them.
There was a problem hiding this comment.
I don’t think lot of people write comments at those places anyway. If someone raises the issue we should address it, but for now let’s stick to this simple solution.
MasseGuillaume
force-pushed
the
symbolic-fold
branch
from
9ec472c to
80905f3
Compare
MasseGuillaume
force-pushed
the
symbolic-fold
branch
from
80905f3 to
b3262ce
Compare
martijnhoekstra
pushed a commit
to martijnhoekstra/scala-collection-compat
that referenced
this pull request
Nov 9, 2022
Add Scala.js cross build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.