Skip to content

add minOption, maxOption, minByOption and maxByOption #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 3, 2020
Merged

add minOption, maxOption, minByOption and maxByOption #345

merged 5 commits into from
Sep 3, 2020

Conversation

xuwei-k
Copy link
Contributor

@xuwei-k xuwei-k commented Jun 25, 2020

No description provided.

@xuwei-k xuwei-k requested a review from julienrf June 27, 2020 04:01
julienrf
julienrf approved these changes Jun 27, 2020
View reviewed changes
Copy link
Contributor

@julienrf julienrf left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @xuwei-k :) This looks good but do you mind adding a test in the shared source directory to assess that we have a consistent behavior between 2.12 and 2.13?

@SethTisue
Copy link
Member

I copied the tests over from scala/scala

@SethTisue SethTisue merged commit c4ef98e into scala:master Sep 3, 2020
@xuwei-k xuwei-k deleted the max-min-Option branch September 3, 2020 04:01
@xuwei-k
Copy link
Contributor Author

xuwei-k commented Sep 3, 2020

🙇 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrf julienrf julienrf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xuwei-k @SethTisue @julienrf