Rewrite retain to filterInPlace
#34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is a subtlety: in 2.12 |
|
The code generated by the rewrite should compile with |
|
Then I guess it becomes a bit complicated, you will have to transform a |
MasseGuillaume
force-pushed
the
feature/Map.retain
branch
from
25b3b51 to
e738da5
Compare
julienrf
reviewed
Jun 11, 2018
| @@ -30,6 +30,28 @@ case class Scalacollectioncompat_NewCollections(index: SemanticdbIndex) | |||
| Symbol("_root_.scala.runtime.Tuple3Zipped.Ops.zipped.") | |||
| ) | |||
|
|
|||
| val retain = | |||
| SymbolMatcher.normalized( | |||
| Symbol("_root_.scala.collection.mutable.MapLike.retain.") | |||
There was a problem hiding this comment.
Oops, I’ve just noticed that this operation is also on mutable.Set. We should support that use case too…
martijnhoekstra
pushed a commit
to martijnhoekstra/scala-collection-compat
that referenced
this pull request
Nov 9, 2022
Add build and release badges
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: scala/collection-strawman#556