Issue 337 factory.newBuilder should return new instances

[oxbowlakes]

I hope that this PR is OK. I have added some tests for the correct behaviour in one commit and then a fix for the issue in a second. However, I cannot get the project to compile any tests locally (even before I have made any changes), so I have checked that the test compiles and fails elsewhere using the existing release.

[julienrf]

Thank you @oxbowlakes!

I forgot something, sorry! You have to sign the Scala CLA.

[oxbowlakes]

That is odd - pretty sure I have contributed before (as I've been through the process several years ago, when contributing to SBT). I have signed the CLA now, not sure how to re-kick the builds

[julienrf]

I’ve restarted the CI, it seems the file compat/src/test/scala/test/scala/collection/FactoryTest.scala is not correctly formatted. Could you please run compat211/Test/scalafmt and commit the changes?

[SethTisue]

contributing to SBT

(sbt is under the Lightbend CLA; Scala modules are under the Scala CLA)

[oxbowlakes]

[IJ]sbt:scala-library-compat> compat211/Test/scalafmt
[error] Expected ';'
[error] Not a valid key: scalafmt (similar: scalafix, scalaHome, scala212)
[error] compat211/Test/scalafmt
[error]                        ^

Under the assumption that the vertical alignment was the problem, I have force-pushed a change to the first commit removing it

[julienrf]

Could you please run compat211/Test/scalafmt?

[oxbowlakes]

As per my previous message, I get an error when I do that, telling me that “scalafmt is not a valid key”

[julienrf]

Sorry, I missed the first part of your message! I forgot that in this project, scalafmt is not available as an sbt-plugin. This means that you have to install it yourself. You can see here the various ways to install it. You can add the scalafmt sbt plugin to the project, locally, just to be able to format from within sbt, or you can install it via coursier, as you prefer. I’m sorry about that, BTW, I wish there was a simpler way… In case you don’t have time to do that, I can manage to reformat the code.

[oxbowlakes]

I've reopened the project in IDEA and selected the "Use scalafmt" option (it notices the .scalaformat.conf file), put the code back to how it was and reformatted it, and believe that the change I made on Saturday was the correct one (i.e. the scalafmt reformatting has resulted in no changes to commit)

[julienrf]

Hey @oxbowlakes,
Thanks again for your patience! I’m really sorry about all these troubles, I wish it was easier to run scalafmt in this project… We definitely need to improve the setup.
Maybe one issue came from the fact that there was no scalafmt version in the configuration file. I’ve added it and applied scalafmt again, it removed some newlines in a file.

[oxbowlakes]

No problem! Thanks for merging the PR - when will a new version of the library be published?

[julienrf]

That’s a good question! There is an ongoing discussion about that in #331. I believe we should be able to publish a patch release soon.

[ijuma]

Seems like things stalled a bit in #331. Any thoughts on how to unblock it?

[lrytz]

Yeah, we need to take a decision and unblock this repo soon. It's on my to-do list.

[NthPortal]

could probably optimise this so that it doesn't have to pattern match each time, and only does so once