Skip to content

Move everything into the scala.collection.compat package #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 17, 2018
Merged

Move everything into the scala.collection.compat package #31

merged 2 commits into from
May 17, 2018

Conversation

lrytz
Copy link
Member

@lrytz lrytz commented May 17, 2018

Fixes #30

Using scala.collection.compat.imm (not .immutable) to avoid
name clashes with scala.collection.immutable.

Fixes #30

Using `scala.collection.compat.imm` (not `.immutable`) to avoid
name clashes with `scala.collection.immutable`.
@lrytz lrytz requested review from szeiger and julienrf May 17, 2018 09:23
@lrytz
Copy link
Member Author

lrytz commented May 17, 2018

Just found out that scala-parallel-collections uses parallel.mutable/immutable. It seems to be OK in practice, so I'll do the same here.

I also found out that parallel collections exports the scala.collection with a split-package clause, we could probably do that as well. But again, in the interest of the Java 9 module system, it's better not to do it.

@julienrf
Copy link
Contributor

OK to use compat.immutable.

@lrytz lrytz merged commit b962a8a into scala:master May 17, 2018
@SethTisue SethTisue changed the title Move everything into the scala.colleciton.compat package Move everything into the scala.collection.compat package May 17, 2018
@julienrf julienrf mentioned this pull request May 4, 2020
martijnhoekstra pushed a commit to martijnhoekstra/scala-collection-compat that referenced this pull request Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants