Allow chaining of filterKeys and mapValues #295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienrf
reviewed
Jan 20, 2020
compat/src/main/scala-2.11_2.12/scala/collection/compat/PackageShared.scala
Show resolved
Hide resolved
NthPortal
force-pushed
the
topic/filterKeys-fix/PR
branch
from
8a29b41 to
9470108
Compare
NthPortal
changed the title
Fix implementation of `IterableView#filterKeys` to not require an implicit CBF, and add a commented-out implementation of `IterableView#mapValues` that does not require an implicit CBF. Add an implicit method to create a CBF so that `IterableView#mapValues` can be chained in front of `IterableView#filterKeys`.
NthPortal
force-pushed
the
topic/filterKeys-fix/PR
branch
from
9470108 to
cc47fe2
Compare
julienrf
approved these changes
Feb 5, 2020
|
Thanks @NthPortal! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix implementation of
IterableView#filterKeysto not require animplicit CBF, and add a commented-out implementation of
IterableView#mapValuesthat does not require an implicit CBF.Add an implicit method to create a CBF so that
IterableView#mapValuescan be chained in front ofIterableView#filterKeys.Fixes #294