Skip to content

Add support for Scala Native #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 1, 2019
Merged

Add support for Scala Native #239

merged 7 commits into from
Aug 1, 2019

Conversation

ekrich
Copy link
Contributor

@ekrich ekrich commented Jul 30, 2019

This should be complete if I understand the build file correctly.

  • Avoids tests for Scala Native
  • Supports production version 0.3.9 and 0.4.0-M2.

Suggestion and reviews are welcomed.

@ekrich
Copy link
Contributor Author

ekrich commented Jul 30, 2019

Well, going to need some excludes for Scala Native in travis.yml.

@SethTisue
Copy link
Member

SethTisue commented Jul 30, 2019

(not sure in this particular case, but sometimes it's easier to enumerate the combos you want with include:, instead of having to exclude: the ones you don't want)

@ekrich
Copy link
Contributor Author

ekrich commented Jul 30, 2019

Very good idea, thanks. Had enough for the day.

@ekrich
Copy link
Contributor Author

ekrich commented Aug 1, 2019

Ready for review.

@SethTisue SethTisue merged commit eff9f2b into scala:master Aug 1, 2019
@SethTisue
Copy link
Member

thank you!

@ekrich ekrich deleted the topic/native branch August 1, 2019 18:06
@ekrich ekrich mentioned this pull request Aug 1, 2019
@gabro
Copy link

gabro commented Aug 5, 2019

🎉

@SethTisue is a release scheduled soon? I'm working on a 2.13 metaconfig release to unblock various projects upstream and I'm using scala-collection-compat there.

@ekrich
Copy link
Contributor Author

ekrich commented Aug 5, 2019

I could also use a release as well for sconfig. I initially copied the code into sconfig because there was no Scala Native release.

@SethTisue SethTisue mentioned this pull request Aug 5, 2019
@SethTisue
Copy link
Member

is a release scheduled soon?

let's roll: #241

@ekrich
Copy link
Contributor Author

ekrich commented Aug 6, 2019

Looks like using the library with Scala Native 0.3.9 and 0.4.0-M2 worked great. ekrich/sconfig#45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants