Upgrade BuildFrom to the latest definition from 2.13 #200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eed3si9n
reviewed
Apr 23, 2019
| @@ -41,7 +39,7 @@ object BuildFrom { | |||
| implicit def fromCanBuildFrom[From, A, C]( | |||
| implicit cbf: CanBuildFrom[From, A, C]): BuildFrom[From, A, C] = | |||
| new BuildFrom[From, A, C] { | |||
| def fromSpecificIterable(from: From)(it: Iterable[A]): C = (cbf(from) ++= it).result() | |||
| def fromSpecific(from: From)(it: IterableOnce[A]): C = (cbf(from) ++= it).result() | |||
There was a problem hiding this comment.
Are there any test coverage for this change?
There was a problem hiding this comment.
I've added a test to ensure that a BuildFrom implementation compiles on all versions.
szeiger
force-pushed
the
wip/fix-buildfrom
branch
from
903a6fa to
413c4f3
Compare
|
I ran a test of Slick with this PR. As expected no code changes were necessary and everything worked fine. The old code was based on |
eed3si9n
approved these changes
Apr 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.