fix the "Factory" type alias definition #152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avoid "import scala.collection.compat._" everywhere in Scala 2.11 and 2.12
collection-compat v0.2.0
```
Welcome to Scala 2.12.6 (Java HotSpot(TM) 64-Bit Server VM, Java 1.8.0_181).
Type in expressions for evaluation. Or try :help.
scala> implicitly[scala.collection.compat.Factory[Int, List[Int]]]
<console>:12: error: could not find implicit value for parameter e: collection.compat.Factory[Int,List[Int]]
implicitly[scala.collection.compat.Factory[Int, List[Int]]]
^
scala> import scala.collection.compat._
import scala.collection.compat._
scala> implicitly[scala.collection.compat.Factory[Int, List[Int]]]
res1: collection.compat.Factory[Int,List[Int]] = scala.collection.generic.GenTraversableFactory$$anon$1@41b12185
```
collection-compat v0.1.1
```
Welcome to Scala 2.12.6 (Java HotSpot(TM) 64-Bit Server VM, Java 1.8.0_181).
Type in expressions for evaluation. Or try :help.
scala> implicitly[scala.collection.compat.Factory[Int, List[Int]]]
res0: scala.collection.compat.Factory[Int,List[Int]] = scala.collection.compat.Factory$$anon$1@33600943
```
|
LGTM, Can you look if it fixes #137. |
smarter
approved these changes
Sep 12, 2018
|
I think the reported problem is not too important, and I do have a preference towards using |
|
After thinking more about it, maybe using a type alias (as proposed in this PR) is better than using Indeed, with Do other people have any thoughts about merging this PR? |
Since Factory is now a transparent type alias to CanBuildFrom, we don’t need anymore conversions from CanBuildFrom to Factory.
|
Thanks @xuwei-k ! |
martijnhoekstra
pushed a commit
to martijnhoekstra/scala-collection-compat
that referenced
this pull request
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
avoid
import scala.collection.compat._everywhere in Scala 2.12 and 2.11collection-compat v0.2.0
collection-compat v0.1.1