Skip to content

Move migration rules here #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 41 commits into from
Apr 20, 2018
Merged

Move migration rules here #15

merged 41 commits into from
Apr 20, 2018

Conversation

julienrf
Copy link
Contributor

This PR copies the content of the migration rule from the scala/collection-strawman repository.

This step is part of scala/collection-strawman#560.

olafurpg and others added 30 commits August 29, 2017 14:07
@olafurpg @julienrf
Setup skeleton for rewriting with scalafix.
7083321
@julienrf
Add a few examples
51edbb4
@julienrf
Add Range, Array and String examples
29cf22b
@olafurpg @julienrf
Depend on collections project in output.
3d46cfa
@olafurpg @julienrf
Almost complete with rewrite.
e2f2425 
Blocked by

- scalameta/scalameta#1037
- scalacenter/scalafix#252
- scalacenter/scalafix#253
@olafurpg @julienrf
Upgrade to scalafix 0.5.0-M3.
e7d3944
@olafurpg @julienrf
Move replaceSymbol from config to rewrite
6f1256e
@olafurpg @julienrf
Use scalafix.syntax.normalized instead of custom rolled.
e679c85
@olafurpg @julienrf
WIP
632d1dc
@olafurpg @julienrf
WIP
d4ea411
@olafurpg @julienrf
WIP
791788d
@olafurpg @julienrf
WIP
2466d82
@olafurpg @julienrf
WIP
c0a5054
@olafurpg @julienrf
Upgrade to M4.
5e31fb3
@julienrf
Add a few more examples
6bf57f5
@olafurpg @julienrf
Add dep on parent project.
891df92
@julienrf
Improve documentation of the migration tool
55a4107
@julienrf
Improve documentation of the migration tool and fix the input and out…
9352c2c 
…put files.
@julienrf
Fix the output and tuned a few rules.
eb10070
@olafurpg
Unimport Predef conversions if used.
e2fa336
@olafurpg
Unimport both augmentString+wrapString if either appears.
3311594
@olafurpg
Prototype toX and to[X] conversions.
4b2d629 
Kind of hacky, but it does mostly the right thing

Remaining failing tests

```diff
-    xs.to(Set)
-    xs.to(Map)
-    xs.iterator
+    xs.to(strawman.collection.immutable.Set)
+    xs.to(strawman.collection.Map)
+    xs.iterator()
```
@julienrf
Fix compilation error in the output
ea68880
@julienrf
Improve the to[X] rules
c41b46e
@julienrf
Fix scalafix build definition
f059ccb
@marcelocenerine
Fix broken scalafix tests
8c9097f
@marcelocenerine
Upgrade Scalafix to 0.5.3
362d648
@marcelocenerine
Scalafix rewrite for lazyZip
ba42911
@julienrf
Remove rewrite rules that are not needed anymore
3edd875
@julienrf
Add failing test case (because of scalacenter/scalafix#478)
66c9265
julienrf added 11 commits December 6, 2017 10:49
@julienrf
Workaround for scalacenter/scalafix#478
fce1608 
This commit can be reverted once the issue is closed
@julienrf
Implement the rule for “import JavaConverters._”
68f9a70
@julienrf
Migrate scala.Seq to strawman.collection.Seq
e8de069
@julienrf
Revert "Migrate scala.Seq to strawman.collection.Seq"
9b8a3ac 
This reverts commit 71dab7c6036ec8b4caf732fc0f0bbec525796629.
@julienrf
Create two distinct scalafix rules targeting 2.12 and 2.13
589712c
@julienrf
Add copyToBuffer rule
ee1bdba
@julienrf
Narrow the node on which the patch is performed
60fac10
@julienrf
Update the migration rule to use 2.13.0-M4-pre-20d3c21
53f832b 
Remove old migration rule that was using the strawman.collection namespace
@julienrf
Move scalafix files into a scalafix subdirectory
8b59395
@julienrf
Add scalafix migration rule.
6873b92 
Copied from https://github.com/scala/collection-strawman
@julienrf
Update README and CONTRIBUTING files with details related to the migr…
00cbc8f 
…ation rules
@julienrf julienrf mentioned this pull request Apr 19, 2018
Merged
@julienrf julienrf merged commit 864b71d into scala:master Apr 20, 2018
@julienrf julienrf deleted the add-scalafix branch April 20, 2018 09:16
@MasseGuillaume MasseGuillaume mentioned this pull request Jun 25, 2018
Closed
martijnhoekstra pushed a commit to martijnhoekstra/scala-collection-compat that referenced this pull request Nov 9, 2022
@julienrf
Merge pull request scala#15 from scala/remove-extensibility-framework
1a46759 
Update to Scala 2.13.0-RC1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@julienrf @olafurpg @marcelocenerine