Skip to content

Bump Scala version to 2.13.0-M5 #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 3, 2018
Merged

Bump Scala version to 2.13.0-M5 #148

merged 1 commit into from
Sep 3, 2018

Conversation

julienrf
Copy link
Contributor

@julienrf julienrf commented Sep 3, 2018

No description provided.

@SethTisue
Copy link
Member 

[error] /home/travis/build/scala/scala-collection-compat/scalafix/output213/src/main/scala/fix/RoughlySrc213.scala:9: value Empty is not a member of object scala.collection.immutable.LazyList
[error]   1 #:: 2 #:: 3 #:: LazyList.Empty
[error]                              ^
[error] /home/travis/build/scala/scala-collection-compat/scalafix/output213/src/main/scala/fix/RoughlySrc213.scala:11: value Empty is not a member of object scala.collection.immutable.LazyList
[error]     case LazyList.Empty => true
[error]                   ^
[error] two errors found

@julienrf
Copy link
Contributor Author

julienrf commented Sep 3, 2018

Could you review this PR, @MasseGuillaume?

@MasseGuillaume
Copy link
Contributor

@SethTisue @julienrf can you add me as a Collaborator?

@SethTisue
Copy link
Member

@MasseGuillaume done, once you accept the invitation to https://github.com/orgs/scala/teams/team-scala

MasseGuillaume
MasseGuillaume approved these changes Sep 3, 2018
View reviewed changes
scalafix/rules/src/main/scala/fix/Roughly.scala
@@ -48,6 +48,10 @@ final case class Roughly(index: SemanticdbIndex, config: RoughlyConfig)
Symbol("_root_.scala.collection.immutable.Stream.append.")
)

val streamEmpty = SymbolMatcher.exact(
Symbol("_root_.scala.collection.immutable.Stream.Empty.")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add it to the scalafix 0.6 branch?

val streamEmpty = exact(
  "scala/collection/immutable/Stream#empty()."
)

https://github.com/scala/scala-collection-compat/blob/scalafix-0.6/scalafix/rules/src/main/scala/fix/Roughly.scala#L44-L46

@julienrf julienrf merged commit 7a6631c into scala:master Sep 3, 2018
@julienrf julienrf deleted the scala-2.13.0-M5 branch September 3, 2018 15:38
martijnhoekstra pushed a commit to martijnhoekstra/scala-collection-compat that referenced this pull request Nov 9, 2022
@Philippus
Merge pull request scala#148 from scala-steward/update/sbt-1.5.5
5f882f1 
Update sbt to 1.5.5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MasseGuillaume MasseGuillaume MasseGuillaume approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@julienrf @SethTisue @MasseGuillaume