CanBuildFrom: Add support for Class and simple form for To (fix #135) #136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MasseGuillaume
commented
Aug 6, 2018
| @@ -33,4 +33,11 @@ object CanBuildFromSrc { | |||
| cbf2("") | |||
| () | |||
| } | |||
|
|
|||
| def f2[T, That](implicit cbf: CanBuildFrom[Nothing, T, That]): Foo[T, That] = | |||
There was a problem hiding this comment.
Previously it would only take CanBuildFrom[Nothing, A, CC[B]] now it accepts CanBuildFrom[Nothing, A, B], but it won't rewrite e.to[CC] => cbf.fromSpecific(e)
MasseGuillaume
commented
Aug 6, 2018
| def f2[T, That](implicit cbf: CanBuildFrom[Nothing, T, That]): Foo[T, That] = | ||
| new Foo | ||
|
|
||
| class Foo[T, That](implicit cbf: CanBuildFrom[Nothing, T, That]) { |
There was a problem hiding this comment.
We now support Classes and Def. I don't see another place where we could insert a CanBuildFrom. Maybe on a type alias (type Foo = CanBuildFrom[Bar, Buz, Qux])?
martijnhoekstra
pushed a commit
to martijnhoekstra/scala-collection-compat
that referenced
this pull request
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.