Fix broken .travis.yml

[MasseGuillaume]

@julienrf it looks like the cross-compat breakOut PR was broken. I'm fixing it here. I'm also re-enabling CI.

[MasseGuillaume]

@julienrf ready for review, this one is important since it unblocks CI.

[julienrf]

How is this related with the PR description?

[MasseGuillaume]

A previous PR was merged but was broken for 2.11. This fix this.

[MasseGuillaume]

This PR disable the CI: #109
This PR does not compile in Scala 2.11: #102

I'm splitting the package object into two parts: 2.11 and 2.12. I have to do this because mutable.TreeMap is only available since 2.11. The package object makes it hard to reuse code between 2.11 and 2.12.

[julienrf]

Would it be possible to have the following?

// scala-2.11_2.12/CompatShared.scala
trait CompatShared {
  implicit class IterableFactoryExtensionMethods[CC[X] <: GenTraversable[X]](private val fact: GenericCompanion[CC]) {
    def from[A](source: TraversableOnce[A]): CC[A] =
      fact.apply(source.toSeq: _*)
  }
  // same for all other definitions that are compatible with 2.11 and 2.12
}

// scala-2.11/compat.scala
package object compat extends CompatShared

// scala-2.12/compat.scala
package object compat extends CompatShared {
  implicit class MutableTreeMapExtensions2(private val fact: m.TreeMap.type) extends AnyVal {
    def from[K: Ordering, V](source: TraversableOnce[(K, V)]): m.TreeMap[K, V] =
      build(m.TreeMap.newBuilder[K, V], source)
  }
  // same with all 2.12 specific definitions
}

So that there is no duplication between scala-2.11 and scala-2.12?

[MasseGuillaume]

You suggest dropping the AnyVal ?

[julienrf]

No, you’re right we should keep extending AnyVal. But we can do it in a way that doesn’t require code duplication between 2.11 and 2.12:

// scala-2.11_2.12
trait CompatShared {
  implicit def sharedExtensions(receiver: Foo): FooExtensions = new CompatShared.FooExtensions(receiver)
}
object CompatShared {
  class FooExtensions(private val receiver: Foo) extends AnyVal {
    // some extension methods…
  }
}

// scala-2.11
package object compat extends CompatShared

// scala-2.12
package object compat extends CompatShared {
  // more extension methods that are specific to scala 2.12
}

[MasseGuillaume]

Oh, of course, nice catch.

[MasseGuillaume]

@julienrf done, rebased.

[MasseGuillaume]

@julienrf ci is green.