Rewrite for strict reverseMap and filterKeys (fix #85) #107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienrf
reviewed
Jul 20, 2018
| i.IntMap(d).mapValues(f2) : i.Map[Int, Int] | ||
| i.LongMap(d2).mapValues(f2) : i.Map[Long, Int] | ||
| i.Map(d).mapValues(id) : i.Map[Int, Int] | ||
| m.LongMap(d2).mapValues(f2) : c.Map[Long, Int] |
There was a problem hiding this comment.
I think users would typically expect a m.LongMap[Int] here, instead of upcasting to Map[Long, Int]. If we rewrite m.LongMap(d2).mapValues(f2) to m.LongMap(d2).mapValues(f2).to(LongMap), does that still cross-compile?
There was a problem hiding this comment.
this is the test input, I'm ascribing to make sure we preserve the same output type.
There was a problem hiding this comment.
It's typed this way in 2.12
def filterKeys(p: (Long) ⇒ Boolean): Map[Long, T]
There was a problem hiding this comment.
Ah, indeed, the return type is Map. I thought that operation was overridden to refine the return type but that’s not the case. Alright, then!
martijnhoekstra
pushed a commit
to martijnhoekstra/scala-collection-compat
that referenced
this pull request
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.