Skip to content

allow explicit ExecutionContext #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nairbv opened this issue Jun 13, 2013 · 1 comment
Closed

allow explicit ExecutionContext #21

nairbv opened this issue Jun 13, 2013 · 1 comment
Labels
enhancement
Milestone
0.9.0-M1

Comments

@nairbv
Copy link

nairbv commented Jun 13, 2013

As mentioned at scala days, it would be nice to be able to explicitly pass an ExecutionContext.
retronym added a commit to retronym/async that referenced this issue Jul 2, 2013
@retronym
An overdue overhaul of macro internals.
fa13894 
 - Avoid reset + retypecheck, instead hang onto the original types/symbols
 - Eliminated duplication between AsyncDefinitionUseAnalyzer and ExprBuilder
   - Instead, decide what do lift *after* running ExprBuilder
   - Account for transitive references local classes/objects. Still a few issues
     with the way we lift them, so the restrictions haven't been removed yet.
 - Make the execution context an regular implicit parameter of the macro
 - Fixes interaction with existential skolems and singleton types

Fixes scala#6, scala#13, scala#16, scala#17, scala#19, scala#21.
retronym added a commit to retronym/async that referenced this issue Jul 3, 2013
@retronym
An overdue overhaul of macro internals.
82232ec 
 - Avoid reset + retypecheck, instead hang onto the original types/symbols
 - Eliminated duplication between AsyncDefinitionUseAnalyzer and ExprBuilder
   - Instead, decide what do lift *after* running ExprBuilder
   - Account for transitive references local classes/objects and lift them
     as needed.
 - Make the execution context an regular implicit parameter of the macro
 - Fixes interaction with existential skolems and singleton types

Fixes scala#6, scala#13, scala#16, scala#17, scala#19, scala#21.
@retronym retronym mentioned this issue Aug 7, 2013
Merged
@phaller
Copy link
Contributor

phaller commented Aug 14, 2013

Fixed in #27

@phaller phaller closed this as completed Aug 14, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
0.9.0-M1
Development

No branches or pull requests
3 participants
@retronym @phaller @nairbv