Skip to content

Drop scalaVersionsByJvm and add sbt-travisci #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

Philippus
Copy link
Member

@Philippus Philippus commented Jul 24, 2019

Applying this PR will:

  • drop scalaVersionsByJvm because we have the alternative of tag based publishing
  • add sbt-travisci to base the values for crossScalaVersions and scalaVersion on the scala versions defined in the travis.yml file

projects still using scalaVersionsByJvm listed below, maybe migrate them to tag based publishing first:

ping @SethTisue @dwijnand

@lrytz
Copy link
Member

lrytz commented Jul 25, 2019

👍 I wanted to do that but didn't push it through all the repos...

add sbt-travisci

Does this also set the scala version outside travis, based on .travis.yml?

scala-xml seems to be (also?) using circle-ci, but i think it would be good to standardize on travis for all modules.

@dwijnand
Copy link
Member

dwijnand commented Jul 25, 2019

Does this also set the scala version outside travis, based on .travis.yml?

Yes. The things that are specific to running on Travis CI are:

  • isTravisBuild in Global will be automatically be set to true if the current build is running under Travis CI.
  • travisPrNumber in Global will be automatically set to the number of the pull request, in case the build is a pull request build.
  • scalaVersion in ThisBuild will be automatically set to TRAVIS_SCALA_VERSION if isTravisBuild is true, otherwise to the last version in crossScalaVersions, and so by default, sbt will assume you want to develop under the last version listed in .travis.yml.

(That last one turned out to be the wrong fallback behaviour alas...)

@lrytz
Copy link
Member

lrytz commented Sep 12, 2019

I continued this in #65. Thanks, @Philippus

@lrytz lrytz closed this Sep 12, 2019
@Philippus Philippus deleted the drop-scala-versions-by-jvm branch October 1, 2019 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants