Consolidate actual Scala module builds. #2
Conversation
|
The master branch in all my forks of scala modules have been updated to use this build. Will submit PRs as soon as this is merged and published. /cc @gkossakowski, @retronym |
| }, | ||
|
|
||
| mappings in (Compile, packageBin) += { | ||
| (baseDirectory.value / s"${name.value}.properties") -> s"${name.value}.properties" |
There was a problem hiding this comment.
Is this needed? I think the resourceGenerators should ensure the properties file goes into the final jar..
There was a problem hiding this comment.
Nope, I verified this is needed.
There was a problem hiding this comment.
Only needed when using OSGi apparently: https://github.com/sbt/sbt-osgi/blob/master/src/main/scala/com/typesafe/sbt/osgi/SbtOsgi.scala#L41
We should open a ticket against sbt-osgi about not using the appropriate resources in Compile key. I think, even now, this is only accidentally fixing the issue. Doing a few inspect tree commands around the scala-xml build leads me to think the current architecture of sbt-osgi is leading to subtle, odd, issues in how to wire things like this.
Basically, this should NOT be needed. It represents a bug that is. You should a comment to that effect in this file and I'll try to follow up on a fix.
Consolidate actual Scala module builds.
Review by @jsuereth. Ran out of time to investigate further, but for now stuck on publishing. I guess I need to publish to bintray?