Skip to content

lighten too-dark-grey background: #bcbcbc → #eee #768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 3, 2017
Merged

lighten too-dark-grey background: #bcbcbc → #eee #768

merged 1 commit into from
May 3, 2017

Conversation

ryan-williams
Copy link
Contributor

fixes #767

@ryan-williams ryan-williams mentioned this pull request May 3, 2017
Closed
SethTisue
SethTisue approved these changes May 3, 2017
View reviewed changes
Copy link
Member

@SethTisue SethTisue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but may conflict or be redundant with work @travissarles is doing? I suggest we merge anyway in the meantime.

@travissarles
Copy link
Contributor

Yes, I'm in the process of copying over the templates you see here https://scala-lang-site.herokuapp.com/
It would be nice to share the layouts and styles between scala/scala-lang and scala/scala.github.com using another repo but it gets a bit messy.

@SethTisue SethTisue merged commit 2fe9dcd into scala:master May 3, 2017
@SethTisue
Copy link
Member

thanks @ryan-williams!

@travissarles sounds great, looking forward to it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SethTisue SethTisue SethTisue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Weirdly dark, grey background on some pages
3 participants
@ryan-williams @travissarles @SethTisue