November 2016 SIP meeting minutes #764
Merged
+97
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Duhemm
suggested changes
Apr 18, 2017
|
|
||
| ### [SIP-27: Trailing commas](http://docs.scala-lang.org/sips/completed/trailing-commas.html) | ||
|
|
||
| Dale talks about how we wanted trailing comments for multi-line elements. Should be easy. Need to discuss which parts of the syntax can use trailing comments. There are two variants of the SIP to vote on. The first is _parameters and arguments_. The other variant is _everywhere_ for consistency. Dale implemented the first one. The second one shouldn't be more hard to implement except for tuples. It needs to fail compilation somehow. |
|
|
||
| Dale talks about how we wanted trailing comments for multi-line elements. Should be easy. Need to discuss which parts of the syntax can use trailing comments. There are two variants of the SIP to vote on. The first is _parameters and arguments_. The other variant is _everywhere_ for consistency. Dale implemented the first one. The second one shouldn't be more hard to implement except for tuples. It needs to fail compilation somehow. | ||
|
|
||
| It could be confusing if trailing comments are only allowed some places and not others. We'd need lots of error messages. |
SethTisue
requested changes
Apr 18, 2017
|
|
||
| * Martin Odersky ([@odersky](https://github.com/odersky)), EPFL | ||
| * Jorge Vicente Cantero ([@jvican](https://github.com/jvican)), Process Lead | ||
| * Seth Tisue ([@SethTisue](https://github.com/SethTisue)), EPFL |
travissarles
force-pushed
the
novembermeetingminutes
branch
from
4d0f5e7 to
c6c9fd9
Compare
|
@jvican any other comments before we merge this? |
jvican
approved these changes
May 18, 2017
| ## Proceedings | ||
| ### Opening Remarks | ||
|
|
||
| **Jorge** We'll talk about the SIPS for META. Eugene will start. |
|
|
||
| **Jorge** We'll talk about the SIPS for META. Eugene will start. | ||
|
|
||
| ### [SIP-28 and SIP-29 - Inline meta](http://docs.scala-lang.org/sips/pending/inline-meta.html) |
|
|
||
| The spec needs to be updated based on Martin's Dotty implementation. We need to split the SIPs for the next meeting. | ||
|
|
||
| **Conclusion** More development needed. Must answer questions on PR. |
There was a problem hiding this comment.
This proposal needs at least another iteration to shape up and provide concrete implementation and specification details. This proposal is therefore under revision -- Eugene, the author, will gather and address more feedback and will resubmit the proposal to analysis when it's ready.
|
|
||
| The main motivation is to prepare for inline. Inline won't work very well without this. Need to flesh this out in SIP. | ||
|
|
||
| **Conclusion** Someone needs to flesh out the SIP and how it relates to inline. |
There was a problem hiding this comment.
There is not an implementation for Scalac, but for Dotty. This proposal is on hold until the Committee decides the specifics of the Inline proposal and how it relates to it. After that, the author will resubmit the proposal for further analysis.
|
|
||
| **Conclusion** Someone needs to flesh out the SIP and how it relates to inline. | ||
|
|
||
| ### [SIP-NN:Static](https://github.com/scala/scala.github.com/pull/491/files) |
|
|
||
| Sébastien says binary compatibility is also an argument in favor of having explicit @static annotation. If in one version you have a static method, in the next version you add a method with same name and signature. The static implementation is not there anymore, then you have broken binary compatibility in a silent way. | ||
|
|
||
| **Conclusion** There are a lot of edge cases when not using annotations. We need to work on this and think about cases around initialization to simplify it. Why do statics need to go first? Show surprising results. There are different implementation strategies. Is this more like @tailrec or does it change generated code? |
There was a problem hiding this comment.
s/we need to work on this/The authors need time to work on the specifics of the proposal and address the Committee's feedback: .../g
|
|
||
| Sébastien says binary compatibility is also an argument in favor of having explicit @static annotation. If in one version you have a static method, in the next version you add a method with same name and signature. The static implementation is not there anymore, then you have broken binary compatibility in a silent way. | ||
|
|
||
| **Conclusion** There are a lot of edge cases when not using annotations. We need to work on this and think about cases around initialization to simplify it. Why do statics need to go first? Show surprising results. There are different implementation strategies. Is this more like @tailrec or does it change generated code? |
There was a problem hiding this comment.
Can we add "This is the first review iteration of this proposal." at the beginning of the conclusion?
travissarles
force-pushed
the
novembermeetingminutes
branch
from
c6c9fd9 to
04e5e9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.