-
Notifications
You must be signed in to change notification settings - Fork 1k
SIP23 update to pending status #679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ATM updated status and provided some background history. Require approval to change SIP status from 'dormant' to 'pending'.
FYI @milessabin @paulp @jvican |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @soronpo, you're on fire today!
I'm happy to merge this PR right away, would you mind removing the sentence I've commented on? If I merge it, it's not necessary anymore 😉.
|
||
New author volunteered to update this SIP, and bring it to an accepted status after committee review. | ||
|
||
Require approval to change SIP status from 'dormant' to 'pending'. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we remove this sentence?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thank you! I'll merge as soon as CI gives the green light.
I think we have hit a Travis timeout @soronpo, can you push again? |
I think you'll have to rebase to get the Travis timeout fix |
Yes. I'll repush both SIPs once this issue is resolve. |
Can you please rebase on top of #685? |
Scala-lang redesign
Literal types were implemented in both Typelevel Scala and Dotty.
New author volunteered to update this SIP, and bring it to an accepted status after committee review.
Require approval to change SIP status from 'dormant' to 'pending'.