Skip to content

SIP23 update to pending status #679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Feb 13, 2017
Merged

SIP23 update to pending status #679

merged 8 commits into from
Feb 13, 2017

Conversation

soronpo
Copy link
Contributor

@soronpo soronpo commented Feb 9, 2017

Literal types were implemented in both Typelevel Scala and Dotty.
New author volunteered to update this SIP, and bring it to an accepted status after committee review.
Require approval to change SIP status from 'dormant' to 'pending'.

soronpo added 2 commits February 9, 2017 19:42
ATM updated status and provided some background history.
Require approval to change SIP status from 'dormant' to 'pending'.
@soronpo
Copy link
Contributor Author

soronpo commented Feb 9, 2017

FYI @milessabin @paulp @jvican

Copy link
Member

@jvican jvican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @soronpo, you're on fire today!

I'm happy to merge this PR right away, would you mind removing the sentence I've commented on? If I merge it, it's not necessary anymore 😉.


New author volunteered to update this SIP, and bring it to an accepted status after committee review.

Require approval to change SIP status from 'dormant' to 'pending'.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove this sentence?

Copy link
Member

@jvican jvican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you! I'll merge as soon as CI gives the green light.

@jvican
Copy link
Member

jvican commented Feb 9, 2017

I think we have hit a Travis timeout @soronpo, can you push again?

@jvican jvican mentioned this pull request Feb 9, 2017
@SethTisue
Copy link
Member

I think you'll have to rebase to get the Travis timeout fix

@jvican
Copy link
Member

jvican commented Feb 13, 2017

Hey @soronpo, can you rebase this once #684 is merged? Hopefully we'll merge your proposal.

@soronpo
Copy link
Contributor Author

soronpo commented Feb 13, 2017

Yes. I'll repush both SIPs once this issue is resolve.

@jvican
Copy link
Member

jvican commented Feb 13, 2017

Can you please rebase on top of #685?

@jvican jvican merged commit 8a75768 into scala:master Feb 13, 2017
bishabosha pushed a commit to bishabosha/docs.scala-lang that referenced this pull request Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants