Added singleton-object page in Korean #672
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n Korean translation to it.
|
Hey @openmaya, could you please rebase on top of latest master? @SethTisue @heathermiller Shall we merge optimistically on this one? My level on Korean is not that great, yet -- but this PR looks like a good improvement! |
|
I called for reviewers on scala/scala Gitter just now, let's see if that produces some review |
|
@jvican Okay I'll try it |
|
@jvican I did it :) |
|
@heathermiller could you check my branch? |
|
LGTM, thanks @openmaya! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and View page was updated because it moved to Implicit-conversions.