Skip to content

Add minutes for the SIP meeting in October 2016 #629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 2, 2016

Conversation

jvican
Copy link
Member

@jvican jvican commented Nov 17, 2016

Review by @SethTisue | @heathermiller.

I will update the rules for the process (with an example) and the status of the
proposals in another PR.

the rest of the Committee except Josh vote in favor of it. According to our new
rules, Josh gets to decide whether the proposal will be readmitted for review or
cancelled (**NOTE**: Josh votes in favor of trailing commas one week after the
meeting). Trailing commas will be reviewed in November.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand. Are we still waiting on Josh's vote?

Copy link
Member Author

@jvican jvican Nov 18, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, Josh has already voted in favor. There was a typo: votes instead of voted.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So then this was accepted?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, not yet. Dale didn't decide on a concrete change of the syntax, so Martin wants to check the final spec and see its implications. We're voting on it this month (29th November) since Dale has already submitted the changes and decided for one of the three options he proposed in its last specification.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're voting a 3rd time? I really don't get this. The minutes definitely don't make it any clearer.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In other words, after the controversy about the process rules, we were deciding whether the trailing commas proposal should be reviewed again or automatically rejected.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None of this was clear in the meeting or in the minutes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forcing everyone to vote (including Josh) for a non-binding vote on whether to review this again is a bit weird, to be honest.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may not be clear in the minutes, I will update it. There may have been some confusion during the meeting... here's the moment when Martin proposed it: https://youtu.be/tXYs9e6Qrb8?t=2266.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The vote was for my benefit: before I go off spending hours updating the SIP for the next meeting, let's check if it wouldn't be rejected regardless. It's no guarantee it'll be accepted, but I'm grateful for the vote.

Dotty, in which the championed scheme is already implemented.

There are no clear winner in the case of local lazy vals, but there seems to be
two clear candidates for the non-local lazy vals (B4-general and B6).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be a link to the proposal so the reader can consult what B4 and B6 are, exactly.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed.

someone pick it up and provide an implementation. Ideally, this implementation
should run in Java 8 and don't depend on var handles. The SIP Process Lead will
wait some time to receive another candidate from the current author, Dmitry. If
he doesn't propose anything, the SIP will be marked as dormant.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is contradictory. At the beginning of this paragraph, it says this is marked as redundant. Then at the bottom it says that we'll wait for someone to be proposed before marking it dormant. Which is it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it's contradictory because we changed our mind several times during the discussion. The one at the end is the final decision. I would update this part of the document to make it clearer.

before. For a proposal to pass, at least 50% of all the Committee
and two-thirds of all the people voting (not counting abstentions) must accept
it. The quorum rule is kept. After some discussion, the Committee unanimously
votes in favor of the new rules.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not clear from these notes which alternative was accepted in the end. Some more detail should be devoted to explaining the voting rule in the minutes. So far, to my knowledge, this is the only place the rule has been written so far.

Has the SIP process been updated with the new voting rule?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I'm on my way to do so. I would prefer to leave the minutes as they are and put all the examples and a clear specification in the process submission rules.

Copy link
Member

@SethTisue SethTisue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did read over the stuff about voting, but it's complicated and I'm confused. I was confused during the meeting, too, so I'm not sure I can really shed any light.

Attendees Present:

* Martin Odersky ([@odersky](https://github.com/odersky)), EPFL
* Seth Tisue ([@SethTisue](https://github.com/SethTisue)), EPFL
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lightbend, not EPFL

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me explain everything in the submission process, and we discuss the clarity of the rules there 😄. If necessary, I can come back to these minutes and modify them accordingly or link to the actual changes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. Can you fix my affiliation before merging, please?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, count on it.

@jvican
Copy link
Member Author

jvican commented Nov 24, 2016

I have updated the document with your comments. For a complete explanation of the voting rules, see this other PR.


**Outcome**: The Committee agrees to wait for Dmitry's response and then mark
the proposal as dormant. The idea is to let someone pick it up and provide an
implementation. Ideally, this implementation should run in Java 8 and don't
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/in/on/ and s/don't/not/

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in last commit 😉.

@jvican
Copy link
Member Author

jvican commented Dec 2, 2016

@heathermiller Does this look good to you?

Copy link
Member

@heathermiller heathermiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some wordings are weird, but they're non-essential for this to be merged.

Both are faster than the existing implementation in the contended case but V4
general is 4x and V6 is only 2x. However, for the uncontended case V4 general is
30% slower than the existing implementation, while V6 is on par, up to +-5%.
Dmitry recommends the V6 case because it's a *pure* win. Memory-wise, V6 would
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does "pure" have to be italicized?

cancelled the vote on the SIP-27: Trailing Commas, and invited the Committee to
discuss new voting rules to help clarify the process voting system.

The issue was caused by a legal void on the rounding of the 70% rule.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A legal void?

@heathermiller heathermiller merged commit 096db18 into scala:master Dec 2, 2016
@heathermiller
Copy link
Member

Oh, @jvican you forgot to link to the minutes on the SIP page.

@jvican
Copy link
Member Author

jvican commented Dec 2, 2016

It's automatic, I think, or at least I remember to have fixed this.

@jvican
Copy link
Member Author

jvican commented Dec 2, 2016

Yes, confirmed locally, it's automatic.

@heathermiller
Copy link
Member

Ok cool, thanks for checking!

@SethTisue
Copy link
Member

will there be a blog post?

@heathermiller
Copy link
Member

There could be. Do you think it would be a good idea?

@SethTisue
Copy link
Member

Sure... maybe a combo on this and the advisory board meeting that just includes brief summaries and links to the two longer documents?

@SethTisue
Copy link
Member

Sure... maybe a combo on this and the advisory board meeting that just includes brief summaries and links to the two longer documents?

PR on this: scala/scala-lang#579

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants