Fix title capitalization #383
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The language backing Liquid templates is quite dubios and the `capitalize` filter wasn't actually doing what was intended. As such, a `partof` property with a value of "foo-bar" was rendered as ['foo', 'bar'] in the title. Using a plugin seems to be the easiest way to solve this problem. Solution from here: http://stackoverflow.com/a/23453152/58808
|
Thanks for the contribution, but currently we're hosted on Github pages, which means that Github disables all custom Jekyll plugins by default. So I don't think this will work :/ |
|
If I'm somehow mistaken about your intentions with this PR, could you please reopen this? |
heathermiller
added a commit
that referenced
this pull request
Oct 8, 2014
|
@heathermiller ah, sorry. I didn't realize this is hosted on GitHub. I'll open a new PR if I'll manage to solve this issue. |
|
@heathermiller opened #384. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.