-
Notifications
You must be signed in to change notification settings - Fork 1k
Reorder tour; a script for reordering #307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
LGTM, thank you! After we get #312 merged, can you rebase this and ping me? |
I don't quite why you've reorganized the numbering? Why was the previous ordering bad and why is this better? Is a Ruby script really necessary for this? (We run on Github pages so Github won't run any plugins for us.) |
good questions. re: GitHub pages, if I understand correctly the idea is to run the reordering script during development and then check the resulting changes into version control. as for ordering, the old order is: Introduction, Abstract Types, Annotations, Classes, Case Classes, Compound Types, Sequence Comprehensions, Extractor Objects, Generic Classes, Implicit Parameters, Inner Classes, Mixin Class Composition, Nested Functions, Anonymous Function Syntax, Currying, Automatic Type-Dependent Closure Construction, Operators, Higher-order Functions, Pattern Matching, Polymorphic Methods, Regular Expression Patterns, Traits, Upper Type Bounds, Lower Type Bounds, Explicitly Typed Self References, Local Type Inference, Unified Types, Variances, Views, XML Processing, Default Parameter values, Named Parameters the new order is: Introduction, Unified Types, Classes, Traits, Mixin Class Composition, Anonymous Function Syntax, Higher-order Functions, Nested Functions, Currying, Case Classes, Pattern Matching the old ordering doesn't have any rhyme or reason to it that I can see — not sure how it got that way. the new ordering seems to me like a reasonable attempt at putting beginning topics first. |
Ah, ok. I see. While I agree with you about the ordering now being more sensible, I don't agree that we should be adding Ruby scripts to be automatically enforcing that ordering. Since we have like 20 or so stub articles, I think it's sufficient to reorder once by hand and assume that the ordering stays that way. We currently don't rely on any external Ruby scripts and the addition of one for such a trivial reason (reordering articles only once) seems like overkill. |
fine w/ me |
It is not really enough to do the renumbering once; if you want to insert an article early in the chain, you have to shift all the numbers after it forward by 1. And then again the next time. |
@S11001001, we've added maybe 1 stub article in like 6 years so I think that manually re-ordering isn't a big issue. @SethTisue Really? Why do we have next/previous links? I didn't realize someone added those. I think those are also unnecessary given that there's a whole TOC that's more easily accessible on the right side of the page... |
Haha! I'm the one who enthusiastically accepted the next/previous link PR for tutorials. Apparently I didn't think these through at the time. While they're nice to have, I think I might revert this commit... I think they don't add as much value for the complexity. |
IIRC—this was a while ago—I chose this ordering to match up with the introduction's order of mentioning topics. |
@heathermiller if after you merge #436 you want to rip out the next/previous links again, it's fine with me. I don't have a strong feeling about it either way. |
The tour introduction also mentions those tour pages that weren't mentioned before.
A script is included that does renumbering.
The workflow is pretty straightforward for using this script to
reorganize a multi-file document.
-x *.md
to print an index; write that to a file.-i
.