Skip to content

highlight using directives in code snippets #2845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 22, 2023
Merged

highlight using directives in code snippets #2845

merged 1 commit into from
Jun 22, 2023

Conversation

bishabosha
Copy link
Member

here are some examples based on snippets from scala-cli documentation

Screenshot 2023-06-22 at 11 14 10

@bishabosha bishabosha requested a review from julienrf June 22, 2023 09:14
julienrf
julienrf reviewed Jun 22, 2023
View reviewed changes
Copy link
Contributor

@julienrf julienrf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks beautiful, but could you please open a similar PR directly in the hljs repository and link it from this one? Eventually, we want to stop using our fork.

@julienrf julienrf assigned bishabosha and unassigned julienrf Jun 22, 2023
@bishabosha bishabosha merged commit 8af7d54 into scala:main Jun 22, 2023
@bishabosha bishabosha deleted the support-using-directives branch June 22, 2023 09:33
@bishabosha bishabosha mentioned this pull request Jun 23, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrf julienrf julienrf left review comments

Assignees

@bishabosha bishabosha

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bishabosha @julienrf