-
Notifications
You must be signed in to change notification settings - Fork 1k
update jp translation to match latest Future docs #2838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I should say, my Japanese is likely subpar in places, so I would appreciate any suggestions from @eed3si9n to make things read more natural. よろしく! |
@rockpunk Thanks for the contribution!
I haven't had time to track all the details in contents so I haven't ok'ed it, but your Japanese seems totally fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few suggestions.
Co-authored-by: eugene yokota <[email protected]>
Co-authored-by: eugene yokota <[email protected]>
Co-authored-by: eugene yokota <[email protected]>
Co-authored-by: eugene yokota <[email protected]>
Thank you for all the suggestions! |
(part of sf scala spree 2022)
This PR addresses japanese translation for #2449