use dotty website code highlighting #2798
Conversation
There was a problem hiding this comment.
The end result looks great, but is it possible to publish that package on npm and reference it from there rather than copying it here?
There was a problem hiding this comment.
Who is it maintained by? Are there any tests?
There was a problem hiding this comment.
Do you mean our own custom package? or the official hljs CDN?
But maybe its better to incubate here (temporarily) so we can improve any issues?
There was a problem hiding this comment.
to be clear, it comes originally from https://github.com/lampepfl/dotty/blob/main/scaladoc/resources/dotty_res/scripts/hljs-scala3.js
There was a problem hiding this comment.
This fixes a lot of issues, but please make sure the syntax highlighting implementation is eventually contributed upstream to highlight.js (see https://github.com/highlightjs/highlight.js/blob/main/src/languages/scala.js) so that we don’t maintain multiple copies of it.
I made a few changes to what was on the dotty website, but in general improvements are:
_digit separators)critically json in string literals renders correctly for the toolkit tutorials:
maybe at some point we can try to update the official highlight-js for scala with these changes