-
Notifications
You must be signed in to change notification settings - Fork 1k
Merge scala 2 and scala 3 themes and guides #2430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Jamie!
I think it would be good to always show the navbar, like it was the case before the Scala 2 / Scala 3 split (see here).
b0ffd87
to
4f5bcda
Compare
scala 3 book
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for addressing all the comments! The result looks good to me, I only left a couple of minor comments.
03a1039
to
bdc11e3
Compare
Just subscribing to receive the notification and prepare a Ukrainian translation of these changes |
Reverse splitting the documentation website into two distinct themes.